Skip to content

Commit 562bf77

Browse files
irengecminyard
authored andcommitted
ipmi: Add missing annotation for ipmi_ssif_lock_cond() and ipmi_ssif_unlock_cond()
Sparse reports a warning at ipmi_ssif_unlock_cond() and ipmi_ssif_lock_cond() warning: context imbalance in ipmi_ssif_lock_cond() - wrong count at exit warning: context imbalance in ipmi_ssif_unlock_cond() - unexpected unlock The root cause is the missing annotation at ipmi_ssif_unlock_cond() and ipmi_ssif_lock_cond() Add the missing __acquires(&ata_scsi_rbuf_lock) Add the missing __releases(&ata_scsi_rbuf_lock) Signed-off-by: Jules Irenge <[email protected]> Message-Id: <[email protected]> Signed-off-by: Corey Minyard <[email protected]>
1 parent 09f5f68 commit 562bf77

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/char/ipmi/ipmi_ssif.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -313,13 +313,15 @@ static int start_send(struct ssif_info *ssif_info,
313313

314314
static unsigned long *ipmi_ssif_lock_cond(struct ssif_info *ssif_info,
315315
unsigned long *flags)
316+
__acquires(&ssif_info->lock)
316317
{
317318
spin_lock_irqsave(&ssif_info->lock, *flags);
318319
return flags;
319320
}
320321

321322
static void ipmi_ssif_unlock_cond(struct ssif_info *ssif_info,
322323
unsigned long *flags)
324+
__releases(&ssif_info->lock)
323325
{
324326
spin_unlock_irqrestore(&ssif_info->lock, *flags);
325327
}

0 commit comments

Comments
 (0)