Skip to content

Commit 5649625

Browse files
KailangYangtiwai
authored andcommitted
ALSA: hda/realtek - Fixed HP right speaker no sound
HP NB right speaker had no sound output. This platform was connected to I2S Amp for speaker out.(None Realtek I2S Amp IC) EC need to check codec GPIO1 pin to initial I2S Amp. Signed-off-by: Kailang Yang <[email protected]> Cc: <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent 7fcd9bb commit 5649625

File tree

1 file changed

+18
-1
lines changed

1 file changed

+18
-1
lines changed

sound/pci/hda/patch_realtek.c

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5975,6 +5975,16 @@ static void alc_fixup_disable_mic_vref(struct hda_codec *codec,
59755975
snd_hda_codec_set_pin_target(codec, 0x19, PIN_VREFHIZ);
59765976
}
59775977

5978+
static void alc285_fixup_hp_gpio_amp_init(struct hda_codec *codec,
5979+
const struct hda_fixup *fix, int action)
5980+
{
5981+
if (action != HDA_FIXUP_ACT_INIT)
5982+
return;
5983+
5984+
msleep(100);
5985+
alc_write_coef_idx(codec, 0x65, 0x0);
5986+
}
5987+
59785988
/* for hda_fixup_thinkpad_acpi() */
59795989
#include "thinkpad_helper.c"
59805990

@@ -6155,6 +6165,7 @@ enum {
61556165
ALC289_FIXUP_ASUS_GA401,
61566166
ALC289_FIXUP_ASUS_GA502,
61576167
ALC256_FIXUP_ACER_MIC_NO_PRESENCE,
6168+
ALC285_FIXUP_HP_GPIO_AMP_INIT,
61586169
};
61596170

61606171
static const struct hda_fixup alc269_fixups[] = {
@@ -7387,6 +7398,12 @@ static const struct hda_fixup alc269_fixups[] = {
73877398
.chained = true,
73887399
.chain_id = ALC256_FIXUP_ASUS_HEADSET_MODE
73897400
},
7401+
[ALC285_FIXUP_HP_GPIO_AMP_INIT] = {
7402+
.type = HDA_FIXUP_FUNC,
7403+
.v.func = alc285_fixup_hp_gpio_amp_init,
7404+
.chained = true,
7405+
.chain_id = ALC285_FIXUP_HP_GPIO_LED
7406+
},
73907407
};
73917408

73927409
static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -7537,7 +7554,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
75377554
SND_PCI_QUIRK(0x103c, 0x84e7, "HP Pavilion 15", ALC269_FIXUP_HP_MUTE_LED_MIC3),
75387555
SND_PCI_QUIRK(0x103c, 0x869d, "HP", ALC236_FIXUP_HP_MUTE_LED),
75397556
SND_PCI_QUIRK(0x103c, 0x8729, "HP", ALC285_FIXUP_HP_GPIO_LED),
7540-
SND_PCI_QUIRK(0x103c, 0x8736, "HP", ALC285_FIXUP_HP_GPIO_LED),
7557+
SND_PCI_QUIRK(0x103c, 0x8736, "HP", ALC285_FIXUP_HP_GPIO_AMP_INIT),
75417558
SND_PCI_QUIRK(0x103c, 0x877a, "HP", ALC285_FIXUP_HP_MUTE_LED),
75427559
SND_PCI_QUIRK(0x103c, 0x877d, "HP", ALC236_FIXUP_HP_MUTE_LED),
75437560
SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC),

0 commit comments

Comments
 (0)