accel/habanalabs: add missing error flow in hl_sysfs_init()

Tomer Tayar · ogabbay · commit 56499c461589 · 2023-04-08T10:44:23.000+03:00
hl_sysfs_fini() is called only if hl_sysfs_init() completes
successfully. Therefore if hl_sysfs_init() fails, need to remove any
sysfs group that was added until that point.

Signed-off-by: Tomer Tayar &lt;ttayar@habana.ai&gt;
Reviewed-by: Oded Gabbay &lt;ogabbay@kernel.org&gt;
Signed-off-by: Oded Gabbay &lt;ogabbay@kernel.org&gt;
diff --git a/drivers/accel/habanalabs/common/sysfs.c b/drivers/accel/habanalabs/common/sysfs.c
@@ -497,10 +497,14 @@ int hl_sysfs_init(struct hl_device *hdev)
 	if (rc) {
 		dev_err(hdev->dev,
 			"Failed to add groups to device, error %d\n", rc);
-		return rc;
+		goto remove_groups;
 	}
 
 	return 0;
+
+remove_groups:
+	device_remove_groups(hdev->dev, hl_dev_attr_groups);
+	return rc;
 }
 
 void hl_sysfs_fini(struct hl_device *hdev)

Original file line number	Diff line number	Diff line change
`@@ -497,10 +497,14 @@ int hl_sysfs_init(struct hl_device *hdev)`
`497`	`497`	`if (rc) {`
`498`	`498`	`dev_err(hdev->dev,`
`499`	`499`	`"Failed to add groups to device, error %d\n", rc);`
`500`		`- return rc;`
	`500`	`+ goto remove_groups;`
`501`	`501`	`}`
`502`	`502`
`503`	`503`	`return 0;`
	`504`	`+`
	`505`	`+remove_groups:`
	`506`	`+ device_remove_groups(hdev->dev, hl_dev_attr_groups);`
	`507`	`+ return rc;`
`504`	`508`	`}`
`505`	`509`
`506`	`510`	`void hl_sysfs_fini(struct hl_device *hdev)`