Skip to content

Commit 5659108

Browse files
johnkeepinggroeck
authored andcommitted
hwmon: (pwm-fan) disable threaded interrupts
The interrupt handler here just increments an atomic counter, jumping to a threaded handler risks missing tachometer pulses and is likely to be more expensive than the simple atomic increment. Signed-off-by: John Keeping <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Guenter Roeck <[email protected]>
1 parent 7e581c1 commit 5659108

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/hwmon/pwm-fan.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -620,8 +620,8 @@ static int pwm_fan_probe(struct platform_device *pdev)
620620
if (tach->irq == -EPROBE_DEFER)
621621
return tach->irq;
622622
if (tach->irq > 0) {
623-
ret = devm_request_irq(dev, tach->irq, pulse_handler, 0,
624-
pdev->name, tach);
623+
ret = devm_request_irq(dev, tach->irq, pulse_handler,
624+
IRQF_NO_THREAD, pdev->name, tach);
625625
if (ret) {
626626
dev_err(dev,
627627
"Failed to request interrupt: %d\n",

0 commit comments

Comments
 (0)