Skip to content

Commit 57005c9

Browse files
larrchjgunthorpe
authored andcommitted
RDMA/hns: Remove redundant hardware opcode definitions
HNS_ROCE_SQ_OPCODE_XXXs and HNS_ROCE_V2_WQE_OP_XXXs have same values, so remove a set of redundant definitions. In addition, remove the suffix of HNS_ROCE_V2_WQE_OP_BIND_MW_TYPE. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Lang Cheng <[email protected]> Signed-off-by: Weihang Li <[email protected]> Signed-off-by: Jason Gunthorpe <[email protected]>
1 parent 1d70ad0 commit 57005c9

File tree

2 files changed

+14
-30
lines changed

2 files changed

+14
-30
lines changed

drivers/infiniband/hw/hns/hns_roce_hw_v2.c

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3169,51 +3169,51 @@ static int hns_roce_v2_poll_one(struct hns_roce_cq *hr_cq,
31693169
/* SQ corresponding to CQE */
31703170
switch (roce_get_field(cqe->byte_4, V2_CQE_BYTE_4_OPCODE_M,
31713171
V2_CQE_BYTE_4_OPCODE_S) & 0x1f) {
3172-
case HNS_ROCE_SQ_OPCODE_SEND:
3172+
case HNS_ROCE_V2_WQE_OP_SEND:
31733173
wc->opcode = IB_WC_SEND;
31743174
break;
3175-
case HNS_ROCE_SQ_OPCODE_SEND_WITH_INV:
3175+
case HNS_ROCE_V2_WQE_OP_SEND_WITH_INV:
31763176
wc->opcode = IB_WC_SEND;
31773177
break;
3178-
case HNS_ROCE_SQ_OPCODE_SEND_WITH_IMM:
3178+
case HNS_ROCE_V2_WQE_OP_SEND_WITH_IMM:
31793179
wc->opcode = IB_WC_SEND;
31803180
wc->wc_flags |= IB_WC_WITH_IMM;
31813181
break;
3182-
case HNS_ROCE_SQ_OPCODE_RDMA_READ:
3182+
case HNS_ROCE_V2_WQE_OP_RDMA_READ:
31833183
wc->opcode = IB_WC_RDMA_READ;
31843184
wc->byte_len = le32_to_cpu(cqe->byte_cnt);
31853185
break;
3186-
case HNS_ROCE_SQ_OPCODE_RDMA_WRITE:
3186+
case HNS_ROCE_V2_WQE_OP_RDMA_WRITE:
31873187
wc->opcode = IB_WC_RDMA_WRITE;
31883188
break;
3189-
case HNS_ROCE_SQ_OPCODE_RDMA_WRITE_WITH_IMM:
3189+
case HNS_ROCE_V2_WQE_OP_RDMA_WRITE_WITH_IMM:
31903190
wc->opcode = IB_WC_RDMA_WRITE;
31913191
wc->wc_flags |= IB_WC_WITH_IMM;
31923192
break;
3193-
case HNS_ROCE_SQ_OPCODE_LOCAL_INV:
3193+
case HNS_ROCE_V2_WQE_OP_LOCAL_INV:
31943194
wc->opcode = IB_WC_LOCAL_INV;
31953195
wc->wc_flags |= IB_WC_WITH_INVALIDATE;
31963196
break;
3197-
case HNS_ROCE_SQ_OPCODE_ATOMIC_COMP_AND_SWAP:
3197+
case HNS_ROCE_V2_WQE_OP_ATOM_CMP_AND_SWAP:
31983198
wc->opcode = IB_WC_COMP_SWAP;
31993199
wc->byte_len = 8;
32003200
break;
3201-
case HNS_ROCE_SQ_OPCODE_ATOMIC_FETCH_AND_ADD:
3201+
case HNS_ROCE_V2_WQE_OP_ATOM_FETCH_AND_ADD:
32023202
wc->opcode = IB_WC_FETCH_ADD;
32033203
wc->byte_len = 8;
32043204
break;
3205-
case HNS_ROCE_SQ_OPCODE_ATOMIC_MASK_COMP_AND_SWAP:
3205+
case HNS_ROCE_V2_WQE_OP_ATOM_MSK_CMP_AND_SWAP:
32063206
wc->opcode = IB_WC_MASKED_COMP_SWAP;
32073207
wc->byte_len = 8;
32083208
break;
3209-
case HNS_ROCE_SQ_OPCODE_ATOMIC_MASK_FETCH_AND_ADD:
3209+
case HNS_ROCE_V2_WQE_OP_ATOM_MSK_FETCH_AND_ADD:
32103210
wc->opcode = IB_WC_MASKED_FETCH_ADD;
32113211
wc->byte_len = 8;
32123212
break;
3213-
case HNS_ROCE_SQ_OPCODE_FAST_REG_WR:
3213+
case HNS_ROCE_V2_WQE_OP_FAST_REG_PMR:
32143214
wc->opcode = IB_WC_REG_MR;
32153215
break;
3216-
case HNS_ROCE_SQ_OPCODE_BIND_MW:
3216+
case HNS_ROCE_V2_WQE_OP_BIND_MW:
32173217
wc->opcode = IB_WC_REG_MR;
32183218
break;
32193219
default:

drivers/infiniband/hw/hns/hns_roce_hw_v2.h

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -179,26 +179,10 @@ enum {
179179
HNS_ROCE_V2_WQE_OP_ATOM_MSK_FETCH_AND_ADD = 0x9,
180180
HNS_ROCE_V2_WQE_OP_FAST_REG_PMR = 0xa,
181181
HNS_ROCE_V2_WQE_OP_LOCAL_INV = 0xb,
182-
HNS_ROCE_V2_WQE_OP_BIND_MW_TYPE = 0xc,
182+
HNS_ROCE_V2_WQE_OP_BIND_MW = 0xc,
183183
HNS_ROCE_V2_WQE_OP_MASK = 0x1f,
184184
};
185185

186-
enum {
187-
HNS_ROCE_SQ_OPCODE_SEND = 0x0,
188-
HNS_ROCE_SQ_OPCODE_SEND_WITH_INV = 0x1,
189-
HNS_ROCE_SQ_OPCODE_SEND_WITH_IMM = 0x2,
190-
HNS_ROCE_SQ_OPCODE_RDMA_WRITE = 0x3,
191-
HNS_ROCE_SQ_OPCODE_RDMA_WRITE_WITH_IMM = 0x4,
192-
HNS_ROCE_SQ_OPCODE_RDMA_READ = 0x5,
193-
HNS_ROCE_SQ_OPCODE_ATOMIC_COMP_AND_SWAP = 0x6,
194-
HNS_ROCE_SQ_OPCODE_ATOMIC_FETCH_AND_ADD = 0x7,
195-
HNS_ROCE_SQ_OPCODE_ATOMIC_MASK_COMP_AND_SWAP = 0x8,
196-
HNS_ROCE_SQ_OPCODE_ATOMIC_MASK_FETCH_AND_ADD = 0x9,
197-
HNS_ROCE_SQ_OPCODE_FAST_REG_WR = 0xa,
198-
HNS_ROCE_SQ_OPCODE_LOCAL_INV = 0xb,
199-
HNS_ROCE_SQ_OPCODE_BIND_MW = 0xc,
200-
};
201-
202186
enum {
203187
/* rq operations */
204188
HNS_ROCE_V2_OPCODE_RDMA_WRITE_IMM = 0x0,

0 commit comments

Comments
 (0)