Skip to content

Commit 57049a1

Browse files
superna9999jbrun3t
authored andcommitted
dt-bindings: clk: amlogic,a1-peripherals-clkc: expose all clock ids
Due to a policy change in clock ID bindings handling, expose all the "private" clock IDs to the public clock dt-bindings to move out of the previous maintenance scheme. This refers to a discussion at [1] & [2] with Krzysztof about the issue with the current maintenance. It was decided to move every A1 peripherals ID to the public clock dt-bindings headers to be merged in a single tree so we can safely add new clocks without having merge issues. [1] https://lore.kernel.org/all/[email protected]/ [2] https://lore.kernel.org/all/[email protected]/ Reviewed-by: Dmitry Rokosov <[email protected]> Acked-by: Krzysztof Kozlowski <[email protected]> Signed-off-by: Neil Armstrong <[email protected]> Link: https://lore.kernel.org/r/20230607-topic-amlogic-upstream-clkid-public-migration-v2-12-38172d17c27a@linaro.org Signed-off-by: Jerome Brunet <[email protected]>
1 parent 165a194 commit 57049a1

File tree

2 files changed

+53
-63
lines changed

2 files changed

+53
-63
lines changed

drivers/clk/meson/a1-peripherals.h

Lines changed: 0 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -46,67 +46,4 @@
4646
/* include the CLKIDs that have been made part of the DT binding */
4747
#include <dt-bindings/clock/amlogic,a1-peripherals-clkc.h>
4848

49-
/*
50-
* CLKID index values for internal clocks
51-
*
52-
* These indices are entirely contrived and do not map onto the hardware.
53-
* It has now been decided to expose everything by default in the DT header:
54-
* include/dt-bindings/clock/a1-peripherals-clkc.h.
55-
* Only the clocks ids we don't want to expose, such as the internal muxes and
56-
* dividers of composite clocks, will remain defined here.
57-
*/
58-
#define CLKID_XTAL_IN 0
59-
#define CLKID_DSPA_SEL 61
60-
#define CLKID_DSPB_SEL 62
61-
#define CLKID_SARADC_SEL 74
62-
#define CLKID_SYS_A_SEL 89
63-
#define CLKID_SYS_A_DIV 90
64-
#define CLKID_SYS_A 91
65-
#define CLKID_SYS_B_SEL 92
66-
#define CLKID_SYS_B_DIV 93
67-
#define CLKID_SYS_B 94
68-
#define CLKID_DSPA_A_DIV 96
69-
#define CLKID_DSPA_A 97
70-
#define CLKID_DSPA_B_DIV 99
71-
#define CLKID_DSPA_B 100
72-
#define CLKID_DSPB_A_DIV 102
73-
#define CLKID_DSPB_A 103
74-
#define CLKID_DSPB_B_DIV 105
75-
#define CLKID_DSPB_B 106
76-
#define CLKID_RTC_32K_IN 107
77-
#define CLKID_RTC_32K_DIV 108
78-
#define CLKID_RTC_32K_XTAL 109
79-
#define CLKID_RTC_32K_SEL 110
80-
#define CLKID_CECB_32K_IN 111
81-
#define CLKID_CECB_32K_DIV 112
82-
#define CLKID_CECA_32K_IN 115
83-
#define CLKID_CECA_32K_DIV 116
84-
#define CLKID_DIV2_PRE 119
85-
#define CLKID_24M_DIV2 120
86-
#define CLKID_GEN_DIV 122
87-
#define CLKID_SARADC_DIV 123
88-
#define CLKID_PWM_A_DIV 125
89-
#define CLKID_PWM_B_DIV 127
90-
#define CLKID_PWM_C_DIV 129
91-
#define CLKID_PWM_D_DIV 131
92-
#define CLKID_PWM_E_DIV 133
93-
#define CLKID_PWM_F_DIV 135
94-
#define CLKID_SPICC_SEL 136
95-
#define CLKID_SPICC_DIV 137
96-
#define CLKID_SPICC_SEL2 138
97-
#define CLKID_TS_DIV 139
98-
#define CLKID_SPIFC_SEL 140
99-
#define CLKID_SPIFC_DIV 141
100-
#define CLKID_SPIFC_SEL2 142
101-
#define CLKID_USB_BUS_SEL 143
102-
#define CLKID_USB_BUS_DIV 144
103-
#define CLKID_SD_EMMC_SEL 145
104-
#define CLKID_SD_EMMC_DIV 146
105-
#define CLKID_PSRAM_SEL 148
106-
#define CLKID_PSRAM_DIV 149
107-
#define CLKID_PSRAM_SEL2 150
108-
#define CLKID_DMC_SEL 151
109-
#define CLKID_DMC_DIV 152
110-
#define CLKID_DMC_SEL2 153
111-
11249
#endif /* __A1_PERIPHERALS_H */

include/dt-bindings/clock/amlogic,a1-peripherals-clkc.h

Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
#ifndef __A1_PERIPHERALS_CLKC_H
1111
#define __A1_PERIPHERALS_CLKC_H
1212

13+
#define CLKID_XTAL_IN 0
1314
#define CLKID_FIXPLL_IN 1
1415
#define CLKID_USB_PHY_IN 2
1516
#define CLKID_USB_CTRL_IN 3
@@ -70,6 +71,8 @@
7071
#define CLKID_CPU_CTRL 58
7172
#define CLKID_ROM 59
7273
#define CLKID_PROC_I2C 60
74+
#define CLKID_DSPA_SEL 61
75+
#define CLKID_DSPB_SEL 62
7376
#define CLKID_DSPA_EN 63
7477
#define CLKID_DSPA_EN_NIC 64
7578
#define CLKID_DSPB_EN 65
@@ -81,6 +84,7 @@
8184
#define CLKID_12M 71
8285
#define CLKID_FCLK_DIV2_DIVN 72
8386
#define CLKID_GEN 73
87+
#define CLKID_SARADC_SEL 74
8488
#define CLKID_SARADC 75
8589
#define CLKID_PWM_A 76
8690
#define CLKID_PWM_B 77
@@ -95,21 +99,70 @@
9599
#define CLKID_SD_EMMC 86
96100
#define CLKID_PSRAM 87
97101
#define CLKID_DMC 88
102+
#define CLKID_SYS_A_SEL 89
103+
#define CLKID_SYS_A_DIV 90
104+
#define CLKID_SYS_A 91
105+
#define CLKID_SYS_B_SEL 92
106+
#define CLKID_SYS_B_DIV 93
107+
#define CLKID_SYS_B 94
98108
#define CLKID_DSPA_A_SEL 95
109+
#define CLKID_DSPA_A_DIV 96
110+
#define CLKID_DSPA_A 97
99111
#define CLKID_DSPA_B_SEL 98
112+
#define CLKID_DSPA_B_DIV 99
113+
#define CLKID_DSPA_B 100
100114
#define CLKID_DSPB_A_SEL 101
115+
#define CLKID_DSPB_A_DIV 102
116+
#define CLKID_DSPB_A 103
101117
#define CLKID_DSPB_B_SEL 104
118+
#define CLKID_DSPB_B_DIV 105
119+
#define CLKID_DSPB_B 106
120+
#define CLKID_RTC_32K_IN 107
121+
#define CLKID_RTC_32K_DIV 108
122+
#define CLKID_RTC_32K_XTAL 109
123+
#define CLKID_RTC_32K_SEL 110
124+
#define CLKID_CECB_32K_IN 111
125+
#define CLKID_CECB_32K_DIV 112
102126
#define CLKID_CECB_32K_SEL_PRE 113
103127
#define CLKID_CECB_32K_SEL 114
128+
#define CLKID_CECA_32K_IN 115
129+
#define CLKID_CECA_32K_DIV 116
104130
#define CLKID_CECA_32K_SEL_PRE 117
105131
#define CLKID_CECA_32K_SEL 118
132+
#define CLKID_DIV2_PRE 119
133+
#define CLKID_24M_DIV2 120
106134
#define CLKID_GEN_SEL 121
135+
#define CLKID_GEN_DIV 122
136+
#define CLKID_SARADC_DIV 123
107137
#define CLKID_PWM_A_SEL 124
138+
#define CLKID_PWM_A_DIV 125
108139
#define CLKID_PWM_B_SEL 126
140+
#define CLKID_PWM_B_DIV 127
109141
#define CLKID_PWM_C_SEL 128
142+
#define CLKID_PWM_C_DIV 129
110143
#define CLKID_PWM_D_SEL 130
144+
#define CLKID_PWM_D_DIV 131
111145
#define CLKID_PWM_E_SEL 132
146+
#define CLKID_PWM_E_DIV 133
112147
#define CLKID_PWM_F_SEL 134
148+
#define CLKID_PWM_F_DIV 135
149+
#define CLKID_SPICC_SEL 136
150+
#define CLKID_SPICC_DIV 137
151+
#define CLKID_SPICC_SEL2 138
152+
#define CLKID_TS_DIV 139
153+
#define CLKID_SPIFC_SEL 140
154+
#define CLKID_SPIFC_DIV 141
155+
#define CLKID_SPIFC_SEL2 142
156+
#define CLKID_USB_BUS_SEL 143
157+
#define CLKID_USB_BUS_DIV 144
158+
#define CLKID_SD_EMMC_SEL 145
159+
#define CLKID_SD_EMMC_DIV 146
113160
#define CLKID_SD_EMMC_SEL2 147
161+
#define CLKID_PSRAM_SEL 148
162+
#define CLKID_PSRAM_DIV 149
163+
#define CLKID_PSRAM_SEL2 150
164+
#define CLKID_DMC_SEL 151
165+
#define CLKID_DMC_DIV 152
166+
#define CLKID_DMC_SEL2 153
114167

115168
#endif /* __A1_PERIPHERALS_CLKC_H */

0 commit comments

Comments
 (0)