Skip to content

Commit 5727375

Browse files
committed
Merge tag 'drm-msm-fixes-2022-04-30' of https://gitlab.freedesktop.org/drm/msm into drm-fixes
single lockdep fix. Signed-off-by: Dave Airlie <[email protected]> From: Rob Clark <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/CAF6AEGtkzqzxDLp82OaKXVrWd7nWZtkxKsuOK1wOGCDz7qF-dA@mail.gmail.com
2 parents ca5e2f4 + 3f65b1e commit 5727375

File tree

3 files changed

+0
-18
lines changed

3 files changed

+0
-18
lines changed

drivers/gpu/drm/msm/dp/dp_display.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -580,12 +580,6 @@ static int dp_hpd_plug_handle(struct dp_display_private *dp, u32 data)
580580
dp->dp_display.connector_type, state);
581581
mutex_unlock(&dp->event_mutex);
582582

583-
/*
584-
* add fail safe mode outside event_mutex scope
585-
* to avoid potiential circular lock with drm thread
586-
*/
587-
dp_panel_add_fail_safe_mode(dp->dp_display.connector);
588-
589583
/* uevent will complete connection part */
590584
return 0;
591585
};

drivers/gpu/drm/msm/dp/dp_panel.c

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -151,15 +151,6 @@ static int dp_panel_update_modes(struct drm_connector *connector,
151151
return rc;
152152
}
153153

154-
void dp_panel_add_fail_safe_mode(struct drm_connector *connector)
155-
{
156-
/* fail safe edid */
157-
mutex_lock(&connector->dev->mode_config.mutex);
158-
if (drm_add_modes_noedid(connector, 640, 480))
159-
drm_set_preferred_mode(connector, 640, 480);
160-
mutex_unlock(&connector->dev->mode_config.mutex);
161-
}
162-
163154
int dp_panel_read_sink_caps(struct dp_panel *dp_panel,
164155
struct drm_connector *connector)
165156
{
@@ -215,8 +206,6 @@ int dp_panel_read_sink_caps(struct dp_panel *dp_panel,
215206
rc = -ETIMEDOUT;
216207
goto end;
217208
}
218-
219-
dp_panel_add_fail_safe_mode(connector);
220209
}
221210

222211
if (panel->aux_cfg_update_done) {

drivers/gpu/drm/msm/dp/dp_panel.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ int dp_panel_init_panel_info(struct dp_panel *dp_panel);
5959
int dp_panel_deinit(struct dp_panel *dp_panel);
6060
int dp_panel_timing_cfg(struct dp_panel *dp_panel);
6161
void dp_panel_dump_regs(struct dp_panel *dp_panel);
62-
void dp_panel_add_fail_safe_mode(struct drm_connector *connector);
6362
int dp_panel_read_sink_caps(struct dp_panel *dp_panel,
6463
struct drm_connector *connector);
6564
u32 dp_panel_get_mode_bpp(struct dp_panel *dp_panel, u32 mode_max_bpp,

0 commit comments

Comments
 (0)