Skip to content

Commit 573f99c

Browse files
jernejskwens
authored andcommitted
Revert "arm64: dts: allwinner: h6: Use RSB for AXP805 PMIC connection"
This reverts commit 531fdbe. Hardware that uses I2C wasn't designed with high speeds in mind, so communication with PMIC via RSB can intermittently fail. Go back to I2C as higher speed and efficiency isn't worth the trouble. Fixes: 531fdbe ("arm64: dts: allwinner: h6: Use RSB for AXP805 PMIC connection") Link: LibreELEC/LibreELEC.tv#7731 Signed-off-by: Jernej Skrabec <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Chen-Yu Tsai <[email protected]>
1 parent 0af2f6b commit 573f99c

File tree

3 files changed

+37
-37
lines changed

3 files changed

+37
-37
lines changed

arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -152,28 +152,12 @@
152152
vcc-pg-supply = <&reg_aldo1>;
153153
};
154154

155-
&r_ir {
156-
linux,rc-map-name = "rc-beelink-gs1";
157-
status = "okay";
158-
};
159-
160-
&r_pio {
161-
/*
162-
* FIXME: We can't add that supply for now since it would
163-
* create a circular dependency between pinctrl, the regulator
164-
* and the RSB Bus.
165-
*
166-
* vcc-pl-supply = <&reg_aldo1>;
167-
*/
168-
vcc-pm-supply = <&reg_aldo1>;
169-
};
170-
171-
&r_rsb {
155+
&r_i2c {
172156
status = "okay";
173157

174-
axp805: pmic@745 {
158+
axp805: pmic@36 {
175159
compatible = "x-powers,axp805", "x-powers,axp806";
176-
reg = <0x745>;
160+
reg = <0x36>;
177161
interrupt-parent = <&r_intc>;
178162
interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_LOW>;
179163
interrupt-controller;
@@ -291,6 +275,22 @@
291275
};
292276
};
293277

278+
&r_ir {
279+
linux,rc-map-name = "rc-beelink-gs1";
280+
status = "okay";
281+
};
282+
283+
&r_pio {
284+
/*
285+
* PL0 and PL1 are used for PMIC I2C
286+
* don't enable the pl-supply else
287+
* it will fail at boot
288+
*
289+
* vcc-pl-supply = <&reg_aldo1>;
290+
*/
291+
vcc-pm-supply = <&reg_aldo1>;
292+
};
293+
294294
&spdif {
295295
pinctrl-names = "default";
296296
pinctrl-0 = <&spdif_tx_pin>;

arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -176,16 +176,12 @@
176176
vcc-pg-supply = <&reg_vcc_wifi_io>;
177177
};
178178

179-
&r_ir {
180-
status = "okay";
181-
};
182-
183-
&r_rsb {
179+
&r_i2c {
184180
status = "okay";
185181

186-
axp805: pmic@745 {
182+
axp805: pmic@36 {
187183
compatible = "x-powers,axp805", "x-powers,axp806";
188-
reg = <0x745>;
184+
reg = <0x36>;
189185
interrupt-parent = <&r_intc>;
190186
interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_LOW>;
191187
interrupt-controller;
@@ -296,6 +292,10 @@
296292
};
297293
};
298294

295+
&r_ir {
296+
status = "okay";
297+
};
298+
299299
&rtc {
300300
clocks = <&ext_osc32k>;
301301
};

arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -113,20 +113,12 @@
113113
vcc-pg-supply = <&reg_aldo1>;
114114
};
115115

116-
&r_ir {
117-
status = "okay";
118-
};
119-
120-
&r_pio {
121-
vcc-pm-supply = <&reg_bldo3>;
122-
};
123-
124-
&r_rsb {
116+
&r_i2c {
125117
status = "okay";
126118

127-
axp805: pmic@745 {
119+
axp805: pmic@36 {
128120
compatible = "x-powers,axp805", "x-powers,axp806";
129-
reg = <0x745>;
121+
reg = <0x36>;
130122
interrupt-parent = <&r_intc>;
131123
interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_LOW>;
132124
interrupt-controller;
@@ -241,6 +233,14 @@
241233
};
242234
};
243235

236+
&r_ir {
237+
status = "okay";
238+
};
239+
240+
&r_pio {
241+
vcc-pm-supply = <&reg_bldo3>;
242+
};
243+
244244
&rtc {
245245
clocks = <&ext_osc32k>;
246246
};

0 commit comments

Comments
 (0)