Skip to content

Commit 582d4ad

Browse files
arndbmchehab
authored andcommitted
media: tc358746: select CONFIG_GENERIC_PHY
The tc358746 driver selects CONFIG_GENERIC_PHY_MIPI_DPHY and links to that, but this fails when CONFIG_GENERIC_PHY is disabled, because Kbuild then never enters the drivers/phy directory for building object files: ERROR: modpost: "phy_mipi_dphy_get_default_config_for_hsclk" [drivers/media/i2c/tc358746.ko] undefined! Add an explicit 'select GENERIC_PHY' here to ensure that the directory is entered, and add another dependency on that symbol so make it more obvious what is going on if another driver has the same problem, as this will produce a Kconfig warning. Link: https://lore.kernel.org/linux-media/[email protected] Fixes: 80a21da ("media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver") Signed-off-by: Arnd Bergmann <[email protected]> Reviewed-by: Marco Felsch <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
1 parent d78b9d6 commit 582d4ad

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

drivers/media/i2c/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1305,6 +1305,7 @@ config VIDEO_TC358746
13051305
select VIDEO_V4L2_SUBDEV_API
13061306
select MEDIA_CONTROLLER
13071307
select V4L2_FWNODE
1308+
select GENERIC_PHY
13081309
select GENERIC_PHY_MIPI_DPHY
13091310
select REGMAP_I2C
13101311
help

drivers/phy/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ config GENERIC_PHY
1818

1919
config GENERIC_PHY_MIPI_DPHY
2020
bool
21+
depends on GENERIC_PHY
2122
help
2223
Generic MIPI D-PHY support.
2324

0 commit comments

Comments
 (0)