drm/amd/pm: fix a potential gpu_metrics_table memory leak

Lang Yu · alexdeucher · commit 583637d66a70 · 2021-12-14T16:10:08.000-05:00
Memory is allocated for gpu_metrics_table in renoir_init_smc_tables(), but not freed in int smu_v12_0_fini_smc_tables(). Free it! Fixes: 95868b8 ("drm/amd/powerplay: add Renoir support for gpu metrics export") Signed-off-by: Lang Yu <lang.yu@amd.com> Reviewed-by: Lijo Lazar <lijo.lazar@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c b/drivers/gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c
@@ -191,6 +191,9 @@ int smu_v12_0_fini_smc_tables(struct smu_context *smu)
 	kfree(smu_table->watermarks_table);
 	smu_table->watermarks_table = NULL;
 
+	kfree(smu_table->gpu_metrics_table);
+	smu_table->gpu_metrics_table = NULL;
+
 	return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -191,6 +191,9 @@ int smu_v12_0_fini_smc_tables(struct smu_context *smu)`
`191`	`191`	`kfree(smu_table->watermarks_table);`
`192`	`192`	`smu_table->watermarks_table = NULL;`
`193`	`193`
	`194`	`+ kfree(smu_table->gpu_metrics_table);`
	`195`	`+ smu_table->gpu_metrics_table = NULL;`
	`196`	`+`
`194`	`197`	`return 0;`
`195`	`198`	`}`
`196`	`199`