Skip to content

Commit 584a340

Browse files
nikhildevshatwarmartinezjavier
authored andcommitted
drm/bridge: tfp410: Set input_bus_flags in atomic_check
input_bus_flags are specified in drm_bridge_timings (legacy) as well as drm_bridge_state->input_bus_cfg.flags The flags from the timings will be deprecated. Bridges are supposed to validate and set the bridge state flags from atomic_check. Implement atomic_check hook for the same. Signed-off-by: Nikhil Devshatwar <[email protected]> Signed-off-by: Aradhya Bhatia <[email protected]> Reviewed-by: Neil Armstrong <[email protected]> Reviewed-by: Tomi Valkeinen <[email protected]> Signed-off-by: Javier Martinez Canillas <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent fdf1d8e commit 584a340

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

drivers/gpu/drm/bridge/ti-tfp410.c

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,22 @@ static u32 *tfp410_get_input_bus_fmts(struct drm_bridge *bridge,
228228
return input_fmts;
229229
}
230230

231+
static int tfp410_atomic_check(struct drm_bridge *bridge,
232+
struct drm_bridge_state *bridge_state,
233+
struct drm_crtc_state *crtc_state,
234+
struct drm_connector_state *conn_state)
235+
{
236+
struct tfp410 *dvi = drm_bridge_to_tfp410(bridge);
237+
238+
/*
239+
* There might be flags negotiation supported in future.
240+
* Set the bus flags in atomic_check statically for now.
241+
*/
242+
bridge_state->input_bus_cfg.flags = dvi->timings.input_bus_flags;
243+
244+
return 0;
245+
}
246+
231247
static const struct drm_bridge_funcs tfp410_bridge_funcs = {
232248
.attach = tfp410_attach,
233249
.detach = tfp410_detach,
@@ -238,6 +254,7 @@ static const struct drm_bridge_funcs tfp410_bridge_funcs = {
238254
.atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
239255
.atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
240256
.atomic_get_input_bus_fmts = tfp410_get_input_bus_fmts,
257+
.atomic_check = tfp410_atomic_check,
241258
};
242259

243260
static const struct drm_bridge_timings tfp410_default_timings = {

0 commit comments

Comments
 (0)