Skip to content

Commit 5872f1a

Browse files
committed
READ_ONCE: Fix comment describing 2x32-bit atomicity
READ_ONCE() permits 64-bit accesses on 32-bit architectures, since this crops up in a few places and is generally harmless because either the upper bits are always zero (e.g. for a virtual address or 32-bit time_t) or the architecture provides 64-bit atomicity anyway. Update the corresponding comment above compiletime_assert_rwonce_type(), which incorrectly states that 32-bit x86 provides 64-bit atomicity, and instead reference 32-bit Armv7 with LPAE. Cc: Thomas Gleixner <[email protected]> Cc: Peter Zijlstra <[email protected]> Reported-by: Jann Horn <[email protected]> Signed-off-by: Will Deacon <[email protected]>
1 parent 1041553 commit 5872f1a

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

include/linux/compiler.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -332,9 +332,9 @@ static inline void *offset_to_ptr(const int *off)
332332

333333
/*
334334
* Yes, this permits 64-bit accesses on 32-bit architectures. These will
335-
* actually be atomic in many cases (namely x86), but for others we rely on
336-
* the access being split into 2x32-bit accesses for a 32-bit quantity (e.g.
337-
* a virtual address) and a strong prevailing wind.
335+
* actually be atomic in some cases (namely Armv7 + LPAE), but for others we
336+
* rely on the access being split into 2x32-bit accesses for a 32-bit quantity
337+
* (e.g. a virtual address) and a strong prevailing wind.
338338
*/
339339
#define compiletime_assert_rwonce_type(t) \
340340
compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \

0 commit comments

Comments
 (0)