Skip to content

Commit 58a18fe

Browse files
joergroedelIngo Molnar
authored andcommitted
x86/mm/64: Do not sync vmalloc/ioremap mappings
Remove the code to sync the vmalloc and ioremap ranges for x86-64. The page-table pages are all pre-allocated so that synchronization is no longer necessary. This is a patch that already went into the kernel as: commit 8bb9bf2 ("x86/mm/64: Do not sync vmalloc/ioremap mappings") But it had to be reverted later because it unveiled a bug from: commit 6eb82f9 ("x86/mm: Pre-allocate P4D/PUD pages for vmalloc area") The bug in that commit causes the P4D/PUD pages not to be correctly allocated, making the synchronization still necessary. That issue got fixed meanwhile upstream: commit 995909a ("x86/mm/64: Do not dereference non-present PGD entries") With that fix it is safe again to remove the page-table synchronization for vmalloc/ioremap ranges on x86-64. Signed-off-by: Joerg Roedel <[email protected]> Signed-off-by: Ingo Molnar <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent c9c9735 commit 58a18fe

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

arch/x86/include/asm/pgtable_64_types.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,4 @@ extern unsigned int ptrs_per_p4d;
159159

160160
#define PGD_KERNEL_START ((PAGE_SIZE / 2) / sizeof(pgd_t))
161161

162-
#define ARCH_PAGE_TABLE_SYNC_MASK (pgtable_l5_enabled() ? PGTBL_PGD_MODIFIED : PGTBL_P4D_MODIFIED)
163-
164162
#endif /* _ASM_X86_PGTABLE_64_DEFS_H */

arch/x86/mm/init_64.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -217,11 +217,6 @@ static void sync_global_pgds(unsigned long start, unsigned long end)
217217
sync_global_pgds_l4(start, end);
218218
}
219219

220-
void arch_sync_kernel_mappings(unsigned long start, unsigned long end)
221-
{
222-
sync_global_pgds(start, end);
223-
}
224-
225220
/*
226221
* NOTE: This function is marked __ref because it calls __init function
227222
* (alloc_bootmem_pages). It's safe to do it ONLY when after_bootmem == 0.

0 commit comments

Comments
 (0)