Skip to content

Commit 58adb5e

Browse files
committed
Merge branch 'pci/hotplug'
- Update hotplug TODO notes (Nam Cao) * pci/hotplug: PCI: hotplug: Remove obsolete sgi_hotplug TODO notes PCI: hotplug: Document unchecked return value of pci_hp_add_bridge()
2 parents ce4a9f1 + b023c1c commit 58adb5e

File tree

1 file changed

+5
-7
lines changed
  • drivers/pci/hotplug

1 file changed

+5
-7
lines changed

drivers/pci/hotplug/TODO

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ cpcihp:
66
->set_power callbacks in struct cpci_hp_controller_ops. Why were they
77
introduced? Can they be removed from the struct?
88

9+
* Returned code from pci_hp_add_bridge() is not checked.
10+
911
cpqphp:
1012

1113
* The driver spawns a kthread cpqhp_event_thread() which is woken by the
@@ -16,6 +18,8 @@ cpqphp:
1618
* A large portion of cpqphp_ctrl.c and cpqphp_pci.c concerns resource
1719
management. Doesn't this duplicate functionality in the core?
1820

21+
* Returned code from pci_hp_add_bridge() is not checked.
22+
1923
ibmphp:
2024

2125
* Implementations of hotplug_slot_ops callbacks such as get_adapter_present()
@@ -43,13 +47,7 @@ ibmphp:
4347
* A large portion of ibmphp_res.c and ibmphp_pci.c concerns resource
4448
management. Doesn't this duplicate functionality in the core?
4549

46-
sgi_hotplug:
47-
48-
* Several functions access the pci_slot member in struct hotplug_slot even
49-
though pci_hotplug.h declares it private. See sn_hp_destroy() for an
50-
example. Either the pci_slot member should no longer be declared private
51-
or sgi_hotplug should store a pointer to it in struct slot. Probably the
52-
former.
50+
* Returned code from pci_hp_add_bridge() is not checked.
5351

5452
shpchp:
5553

0 commit comments

Comments
 (0)