File tree Expand file tree Collapse file tree 1 file changed +5
-7
lines changed Expand file tree Collapse file tree 1 file changed +5
-7
lines changed Original file line number Diff line number Diff line change 6
6
->set_power callbacks in struct cpci_hp_controller_ops. Why were they
7
7
introduced? Can they be removed from the struct?
8
8
9
+ * Returned code from pci_hp_add_bridge() is not checked.
10
+
9
11
cpqphp:
10
12
11
13
* The driver spawns a kthread cpqhp_event_thread() which is woken by the
@@ -16,6 +18,8 @@ cpqphp:
16
18
* A large portion of cpqphp_ctrl.c and cpqphp_pci.c concerns resource
17
19
management. Doesn't this duplicate functionality in the core?
18
20
21
+ * Returned code from pci_hp_add_bridge() is not checked.
22
+
19
23
ibmphp:
20
24
21
25
* Implementations of hotplug_slot_ops callbacks such as get_adapter_present()
@@ -43,13 +47,7 @@ ibmphp:
43
47
* A large portion of ibmphp_res.c and ibmphp_pci.c concerns resource
44
48
management. Doesn't this duplicate functionality in the core?
45
49
46
- sgi_hotplug:
47
-
48
- * Several functions access the pci_slot member in struct hotplug_slot even
49
- though pci_hotplug.h declares it private. See sn_hp_destroy() for an
50
- example. Either the pci_slot member should no longer be declared private
51
- or sgi_hotplug should store a pointer to it in struct slot. Probably the
52
- former.
50
+ * Returned code from pci_hp_add_bridge() is not checked.
53
51
54
52
shpchp:
55
53
You can’t perform that action at this time.
0 commit comments