Skip to content

Commit 58d6ccc

Browse files
committed
media: atomisp: don't produce errs for ignored IRQs
Depending on the ISP-specific HAS_NO_INPUT_FORMATTER macro, some IRQs will be ignored by the driver. Yet, those keep happening, as reported by this debug print: [ 61.620746] atomisp-isp2 0000:00:03.0: atomisp_css_irq_enable: css irq info 0x00000004: disable. Causing this warning: [ 61.620749] atomisp-isp2 0000:00:03.0: atomisp_css_irq_enable:Invalid irq info. Well, if this is a normal situation, just ignore it without warnings. Signed-off-by: Mauro Carvalho Chehab <[email protected]>
1 parent cf3cd3b commit 58d6ccc

File tree

1 file changed

+7
-2
lines changed
  • drivers/staging/media/atomisp/pci

1 file changed

+7
-2
lines changed

drivers/staging/media/atomisp/pci/sh_css.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2660,11 +2660,16 @@ enum ia_css_err ia_css_irq_enable(
26602660
case IA_CSS_IRQ_INFO_INPUT_SYSTEM_ERROR:
26612661
irq = virq_isys_csi;
26622662
break;
2663-
#endif
2664-
#if !defined(HAS_NO_INPUT_FORMATTER)
26652663
case IA_CSS_IRQ_INFO_IF_ERROR:
26662664
irq = virq_ifmt0_id;
26672665
break;
2666+
#else
2667+
case IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF:
2668+
case IA_CSS_IRQ_INFO_CSS_RECEIVER_EOF:
2669+
case IA_CSS_IRQ_INFO_INPUT_SYSTEM_ERROR:
2670+
case IA_CSS_IRQ_INFO_IF_ERROR:
2671+
/* Just ignore those unused IRQs without printing errors */
2672+
return IA_CSS_SUCCESS;
26682673
#endif
26692674
case IA_CSS_IRQ_INFO_DMA_ERROR:
26702675
irq = virq_dma;

0 commit comments

Comments
 (0)