Skip to content

Commit 58fc1da

Browse files
jhovoldgregkh
authored andcommitted
USB: cdc-acm: fix break reporting
A recent change that started reporting break events forgot to push the event to the line discipline, which meant that a detected break would not be reported until further characters had been receive (the port could even have been closed and reopened in between). Fixes: 08dff27 ("cdc-acm: fix BREAK rx code path adding necessary calls") Cc: [email protected] Acked-by: Oliver Neukum <[email protected]> Signed-off-by: Johan Hovold <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 65a205e commit 58fc1da

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/usb/class/cdc-acm.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -340,6 +340,9 @@ static void acm_process_notification(struct acm *acm, unsigned char *buf)
340340
acm->iocount.overrun++;
341341
spin_unlock_irqrestore(&acm->read_lock, flags);
342342

343+
if (newctrl & ACM_CTRL_BRK)
344+
tty_flip_buffer_push(&acm->port);
345+
343346
if (difference)
344347
wake_up_all(&acm->wioctl);
345348

0 commit comments

Comments
 (0)