Skip to content

Commit 5908560

Browse files
Marco Paganiogabbay
authored andcommitted
habanalabs: added return value check for hl_fw_dynamic_send_clear_cmd()
The clang-analyzer reported a warning: "Value stored to 'rc' is never read". The return value check for the first hl_fw_dynamic_send_clear_cmd() call in hl_fw_dynamic_send_protocol_cmd() appears to be missing. Signed-off-by: Marco Pagani <[email protected]> Reviewed-by: Oded Gabbay <[email protected]> Signed-off-by: Oded Gabbay <[email protected]>
1 parent 01907ba commit 5908560

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/misc/habanalabs/common/firmware_if.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1783,6 +1783,8 @@ int hl_fw_dynamic_send_protocol_cmd(struct hl_device *hdev,
17831783

17841784
/* first send clear command to clean former commands */
17851785
rc = hl_fw_dynamic_send_clear_cmd(hdev, fw_loader);
1786+
if (rc)
1787+
return rc;
17861788

17871789
/* send the actual command */
17881790
hl_fw_dynamic_send_cmd(hdev, fw_loader, cmd, size);

0 commit comments

Comments
 (0)