Skip to content

Commit 590a87f

Browse files
xpardee-createij-intel
authored andcommitted
platform/x86:intel/pmc: Use DEFINE_SHOW_STORE_ATTRIBUTE macro
DEFINE_SHOW_STORE_ATTRIBUTE() macro can be used for the ltr_ignore attribute for better readability. Signed-off-by: Xi Pardee <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Ilpo Järvinen <[email protected]> Signed-off-by: Ilpo Järvinen <[email protected]>
1 parent 97eb32b commit 590a87f

File tree

1 file changed

+2
-14
lines changed
  • drivers/platform/x86/intel/pmc

1 file changed

+2
-14
lines changed

drivers/platform/x86/intel/pmc/core.c

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -529,19 +529,7 @@ static int pmc_core_ltr_ignore_show(struct seq_file *s, void *unused)
529529
{
530530
return 0;
531531
}
532-
533-
static int pmc_core_ltr_ignore_open(struct inode *inode, struct file *file)
534-
{
535-
return single_open(file, pmc_core_ltr_ignore_show, inode->i_private);
536-
}
537-
538-
static const struct file_operations pmc_core_ltr_ignore_ops = {
539-
.open = pmc_core_ltr_ignore_open,
540-
.read = seq_read,
541-
.write = pmc_core_ltr_ignore_write,
542-
.llseek = seq_lseek,
543-
.release = single_release,
544-
};
532+
DEFINE_SHOW_STORE_ATTRIBUTE(pmc_core_ltr_ignore);
545533

546534
static void pmc_core_slps0_dbg_latch(struct pmc_dev *pmcdev, bool reset)
547535
{
@@ -1218,7 +1206,7 @@ static void pmc_core_dbgfs_register(struct pmc_dev *pmcdev)
12181206
pmcdev, &pmc_core_ppfear_fops);
12191207

12201208
debugfs_create_file("ltr_ignore", 0644, dir, pmcdev,
1221-
&pmc_core_ltr_ignore_ops);
1209+
&pmc_core_ltr_ignore_fops);
12221210

12231211
debugfs_create_file("ltr_show", 0444, dir, pmcdev, &pmc_core_ltr_fops);
12241212

0 commit comments

Comments
 (0)