Skip to content

Commit 591ae6b

Browse files
Ye ZhangBartosz Golaszewski
authored andcommitted
gpio: rockchip: explan the format of the GPIO version ID
Remove redundant comments and provide a detailed explanation of the GPIO version ID. Signed-off-by: Ye Zhang <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Reviewed-by: Sebastian Reichel <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bartosz Golaszewski <[email protected]>
1 parent e106b1d commit 591ae6b

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

drivers/gpio/gpio-rockchip.c

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,15 @@
2626
#include "../pinctrl/core.h"
2727
#include "../pinctrl/pinctrl-rockchip.h"
2828

29+
/*
30+
* Version ID Register
31+
* Bits [31:24] - Major Version
32+
* Bits [23:16] - Minor Version
33+
* Bits [15:0] - Revision Number
34+
*/
2935
#define GPIO_TYPE_V1 (0) /* GPIO Version ID reserved */
30-
#define GPIO_TYPE_V2 (0x01000C2B) /* GPIO Version ID 0x01000C2B */
31-
#define GPIO_TYPE_V2_1 (0x0101157C) /* GPIO Version ID 0x0101157C */
36+
#define GPIO_TYPE_V2 (0x01000C2B)
37+
#define GPIO_TYPE_V2_1 (0x0101157C)
3238

3339
static const struct rockchip_gpio_regs gpio_regs_v1 = {
3440
.port_dr = 0x00,

0 commit comments

Comments
 (0)