Skip to content

Commit 59f6000

Browse files
author
Andreas Gruenbacher
committed
gfs2: Remove ill-placed consistency check
This consistency check was originally added by commit 9287c64 ("gfs2: Fix occasional glock use-after-free"). It is ill-placed in gfs2_glock_free() because if it holds there, it must equally hold in __gfs2_glock_put() already. Either way, the check doesn't seem necessary anymore. Signed-off-by: Andreas Gruenbacher <[email protected]>
1 parent 7a1ad9d commit 59f6000

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

fs/gfs2/glock.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,6 @@ void gfs2_glock_free(struct gfs2_glock *gl)
170170
{
171171
struct gfs2_sbd *sdp = gl->gl_name.ln_sbd;
172172

173-
gfs2_glock_assert_withdraw(gl, atomic_read(&gl->gl_revokes) == 0);
174173
rhashtable_remove_fast(&gl_hash_table, &gl->gl_node, ht_parms);
175174
smp_mb();
176175
wake_up_glock(gl);

0 commit comments

Comments
 (0)