Skip to content

Commit 5a242d8

Browse files
ita93gregkh
authored andcommitted
samples/kobject: Use sysfs_emit instead of sprintf
sysfs_emit() is preferred over sprintf() when formatting the value to be returned to user space in show() functions, because it knows about sysfs buffer specifics and has sanity checks. Signed-off-by: Nguyen Dinh Phi <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent b0f6807 commit 5a242d8

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

samples/kobject/kobject-example.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ static int bar;
2828
static ssize_t foo_show(struct kobject *kobj, struct kobj_attribute *attr,
2929
char *buf)
3030
{
31-
return sprintf(buf, "%d\n", foo);
31+
return sysfs_emit(buf, "%d\n", foo);
3232
}
3333

3434
static ssize_t foo_store(struct kobject *kobj, struct kobj_attribute *attr,
@@ -60,7 +60,7 @@ static ssize_t b_show(struct kobject *kobj, struct kobj_attribute *attr,
6060
var = baz;
6161
else
6262
var = bar;
63-
return sprintf(buf, "%d\n", var);
63+
return sysfs_emit(buf, "%d\n", var);
6464
}
6565

6666
static ssize_t b_store(struct kobject *kobj, struct kobj_attribute *attr,

samples/kobject/kset-example.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ static void foo_release(struct kobject *kobj)
112112
static ssize_t foo_show(struct foo_obj *foo_obj, struct foo_attribute *attr,
113113
char *buf)
114114
{
115-
return sprintf(buf, "%d\n", foo_obj->foo);
115+
return sysfs_emit(buf, "%d\n", foo_obj->foo);
116116
}
117117

118118
static ssize_t foo_store(struct foo_obj *foo_obj, struct foo_attribute *attr,
@@ -144,7 +144,7 @@ static ssize_t b_show(struct foo_obj *foo_obj, struct foo_attribute *attr,
144144
var = foo_obj->baz;
145145
else
146146
var = foo_obj->bar;
147-
return sprintf(buf, "%d\n", var);
147+
return sysfs_emit(buf, "%d\n", var);
148148
}
149149

150150
static ssize_t b_store(struct foo_obj *foo_obj, struct foo_attribute *attr,

0 commit comments

Comments
 (0)