Skip to content

Commit 5a3c46b

Browse files
ckborahmattrope
authored andcommitted
drm/i915/display: Set correct voltage level for 480MHz CDCLK
According to Bspec, the voltage level for 480MHz is to be set as 1 instead of 2. BSpec: 49208 Fixes: 06f1b06 ("drm/i915/display: Add 480 MHz CDCLK steps for RPL-U") v2: rebase Signed-off-by: Chaitanya Kumar Borah <[email protected]> Reviewed-by: Mika Kahola <[email protected]> Signed-off-by: Matt Roper <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent f917130 commit 5a3c46b

File tree

1 file changed

+26
-4
lines changed

1 file changed

+26
-4
lines changed

drivers/gpu/drm/i915/display/intel_cdclk.c

Lines changed: 26 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1453,6 +1453,18 @@ static u8 tgl_calc_voltage_level(int cdclk)
14531453
return 0;
14541454
}
14551455

1456+
static u8 rplu_calc_voltage_level(int cdclk)
1457+
{
1458+
if (cdclk > 556800)
1459+
return 3;
1460+
else if (cdclk > 480000)
1461+
return 2;
1462+
else if (cdclk > 312000)
1463+
return 1;
1464+
else
1465+
return 0;
1466+
}
1467+
14561468
static void icl_readout_refclk(struct drm_i915_private *dev_priv,
14571469
struct intel_cdclk_config *cdclk_config)
14581470
{
@@ -3397,6 +3409,13 @@ static const struct intel_cdclk_funcs mtl_cdclk_funcs = {
33973409
.calc_voltage_level = tgl_calc_voltage_level,
33983410
};
33993411

3412+
static const struct intel_cdclk_funcs rplu_cdclk_funcs = {
3413+
.get_cdclk = bxt_get_cdclk,
3414+
.set_cdclk = bxt_set_cdclk,
3415+
.modeset_calc_cdclk = bxt_modeset_calc_cdclk,
3416+
.calc_voltage_level = rplu_calc_voltage_level,
3417+
};
3418+
34003419
static const struct intel_cdclk_funcs tgl_cdclk_funcs = {
34013420
.get_cdclk = bxt_get_cdclk,
34023421
.set_cdclk = bxt_set_cdclk,
@@ -3539,14 +3558,17 @@ void intel_init_cdclk_hooks(struct drm_i915_private *dev_priv)
35393558
dev_priv->display.funcs.cdclk = &tgl_cdclk_funcs;
35403559
dev_priv->display.cdclk.table = dg2_cdclk_table;
35413560
} else if (IS_ALDERLAKE_P(dev_priv)) {
3542-
dev_priv->display.funcs.cdclk = &tgl_cdclk_funcs;
35433561
/* Wa_22011320316:adl-p[a0] */
3544-
if (IS_ADLP_DISPLAY_STEP(dev_priv, STEP_A0, STEP_B0))
3562+
if (IS_ADLP_DISPLAY_STEP(dev_priv, STEP_A0, STEP_B0)) {
35453563
dev_priv->display.cdclk.table = adlp_a_step_cdclk_table;
3546-
else if (IS_ADLP_RPLU(dev_priv))
3564+
dev_priv->display.funcs.cdclk = &tgl_cdclk_funcs;
3565+
} else if (IS_ADLP_RPLU(dev_priv)) {
35473566
dev_priv->display.cdclk.table = rplu_cdclk_table;
3548-
else
3567+
dev_priv->display.funcs.cdclk = &rplu_cdclk_funcs;
3568+
} else {
35493569
dev_priv->display.cdclk.table = adlp_cdclk_table;
3570+
dev_priv->display.funcs.cdclk = &tgl_cdclk_funcs;
3571+
}
35503572
} else if (IS_ROCKETLAKE(dev_priv)) {
35513573
dev_priv->display.funcs.cdclk = &tgl_cdclk_funcs;
35523574
dev_priv->display.cdclk.table = rkl_cdclk_table;

0 commit comments

Comments
 (0)