Skip to content

Commit 5a4f905

Browse files
Frederic WeisbeckerNeeraj Upadhyay
authored andcommitted
rcu/nocb: Remove halfway (de-)offloading handling from rcu_core()'s QS reporting
RCU core can't be running anymore while in the middle of (de-)offloading since this sort of transition now only applies to offline CPUs. The locked callback acceleration handling during the transition can therefore be removed. Signed-off-by: Frederic Weisbecker <[email protected]> Signed-off-by: Paul E. McKenney <[email protected]> Reviewed-by: Paul E. McKenney <[email protected]> Signed-off-by: Neeraj Upadhyay <[email protected]>
1 parent d2e7f55 commit 5a4f905

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

kernel/rcu/tree.c

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2386,7 +2386,6 @@ rcu_report_qs_rdp(struct rcu_data *rdp)
23862386
{
23872387
unsigned long flags;
23882388
unsigned long mask;
2389-
bool needacc = false;
23902389
struct rcu_node *rnp;
23912390

23922391
WARN_ON_ONCE(rdp->cpu != smp_processor_id());
@@ -2423,23 +2422,11 @@ rcu_report_qs_rdp(struct rcu_data *rdp)
24232422
* to return true. So complain, but don't awaken.
24242423
*/
24252424
WARN_ON_ONCE(rcu_accelerate_cbs(rnp, rdp));
2426-
} else if (!rcu_segcblist_completely_offloaded(&rdp->cblist)) {
2427-
/*
2428-
* ...but NOCB kthreads may miss or delay callbacks acceleration
2429-
* if in the middle of a (de-)offloading process.
2430-
*/
2431-
needacc = true;
24322425
}
24332426

24342427
rcu_disable_urgency_upon_qs(rdp);
24352428
rcu_report_qs_rnp(mask, rnp, rnp->gp_seq, flags);
24362429
/* ^^^ Released rnp->lock */
2437-
2438-
if (needacc) {
2439-
rcu_nocb_lock_irqsave(rdp, flags);
2440-
rcu_accelerate_cbs_unlocked(rnp, rdp);
2441-
rcu_nocb_unlock_irqrestore(rdp, flags);
2442-
}
24432430
}
24442431
}
24452432

0 commit comments

Comments
 (0)