Skip to content

Commit 5a993e5

Browse files
Revert "scsi: qla2xxx: Fix memory leak when sending I/O fails"
This reverts commit 2f856d4. This patch was found to introduce a double free regression. The issue it originally attempted to address was fixed in patch f45bca8 ("scsi: qla2xxx: Fix double scsi_done for abort path"). Link: https://lore.kernel.org/r/[email protected] Requested-by: Himanshu Madhani <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent 0b7a223 commit 5a993e5

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

drivers/scsi/qla2xxx/qla_os.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -909,8 +909,6 @@ qla2xxx_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd)
909909

910910
qc24_host_busy_free_sp:
911911
sp->free(sp);
912-
CMD_SP(cmd) = NULL;
913-
qla2x00_rel_sp(sp);
914912

915913
qc24_target_busy:
916914
return SCSI_MLQUEUE_TARGET_BUSY;
@@ -994,8 +992,6 @@ qla2xxx_mqueuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd,
994992

995993
qc24_host_busy_free_sp:
996994
sp->free(sp);
997-
CMD_SP(cmd) = NULL;
998-
qla2xxx_rel_qpair_sp(sp->qpair, sp);
999995

1000996
qc24_target_busy:
1001997
return SCSI_MLQUEUE_TARGET_BUSY;

0 commit comments

Comments
 (0)