Skip to content

Commit 5aaec71

Browse files
fabioestevambroonie
authored andcommitted
ASoC: dt-bindings: simple-card: Fix 'make dt_binding_check' warnings
The following build warnings are seen with 'make dt_binding_check': Documentation/devicetree/bindings/sound/simple-card.example.dts:209.46-211.15: Warning (unit_address_vs_reg): /example-4/sound/simple-audio-card,cpu@0: node has a unit name, but no reg or ranges property Documentation/devicetree/bindings/sound/simple-card.example.dts:213.37-215.15: Warning (unit_address_vs_reg): /example-4/sound/simple-audio-card,cpu@1: node has a unit name, but no reg or ranges property Documentation/devicetree/bindings/sound/simple-card.example.dts:250.42-261.15: Warning (unit_address_vs_reg): /example-5/sound/simple-audio-card,dai-link@0: node has a unit name, but no reg or ranges property Documentation/devicetree/bindings/sound/simple-card.example.dts:263.42-288.15: Warning (unit_address_vs_reg): /example-5/sound/simple-audio-card,dai-link@1: node has a unit name, but no reg or ranges property Documentation/devicetree/bindings/sound/simple-card.example.dts:270.32-272.19: Warning (unit_address_vs_reg): /example-5/sound/simple-audio-card,dai-link@1/cpu@0: node has a unit name, but no reg or ranges property Documentation/devicetree/bindings/sound/simple-card.example.dts:273.23-275.19: Warning (unit_address_vs_reg): /example-5/sound/simple-audio-card,dai-link@1/cpu@1: node has a unit name, but no reg or ranges property Documentation/devicetree/bindings/sound/simple-card.example.dts:276.23-278.19: Warning (unit_address_vs_reg): /example-5/sound/simple-audio-card,dai-link@1/cpu@2: node has a unit name, but no reg or ranges property Documentation/devicetree/bindings/sound/simple-card.example.dts:279.23-281.19: Warning (unit_address_vs_reg): /example-5/sound/simple-audio-card,dai-link@1/cpu@3: node has a unit name, but no reg or ranges property Documentation/devicetree/bindings/sound/simple-card.example.dts:290.42-303.15: Warning (unit_address_vs_reg): /example-5/sound/simple-audio-card,dai-link@2: node has a unit name, but no reg or ranges property Fix them all. Signed-off-by: Fabio Estevam <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent 1eb96c1 commit 5aaec71

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

Documentation/devicetree/bindings/sound/simple-card.yaml

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -380,6 +380,8 @@ examples:
380380
- |
381381
sound {
382382
compatible = "simple-audio-card";
383+
#address-cells = <1>;
384+
#size-cells = <0>;
383385
384386
simple-audio-card,name = "rsnd-ak4643";
385387
simple-audio-card,format = "left_j";
@@ -393,10 +395,12 @@ examples:
393395
"ak4642 Playback", "DAI1 Playback";
394396
395397
dpcmcpu: simple-audio-card,cpu@0 {
398+
reg = <0>;
396399
sound-dai = <&rcar_sound 0>;
397400
};
398401
399402
simple-audio-card,cpu@1 {
403+
reg = <1>;
400404
sound-dai = <&rcar_sound 1>;
401405
};
402406
@@ -420,6 +424,8 @@ examples:
420424
- |
421425
sound {
422426
compatible = "simple-audio-card";
427+
#address-cells = <1>;
428+
#size-cells = <0>;
423429
424430
simple-audio-card,routing =
425431
"pcm3168a Playback", "DAI1 Playback",
@@ -428,6 +434,7 @@ examples:
428434
"pcm3168a Playback", "DAI4 Playback";
429435
430436
simple-audio-card,dai-link@0 {
437+
reg = <0>;
431438
format = "left_j";
432439
bitclock-master = <&sndcpu0>;
433440
frame-master = <&sndcpu0>;
@@ -441,22 +448,23 @@ examples:
441448
};
442449
443450
simple-audio-card,dai-link@1 {
451+
reg = <1>;
444452
format = "i2s";
445453
bitclock-master = <&sndcpu1>;
446454
frame-master = <&sndcpu1>;
447455
448456
convert-channels = <8>; /* TDM Split */
449457
450-
sndcpu1: cpu@0 {
458+
sndcpu1: cpu0 {
451459
sound-dai = <&rcar_sound 1>;
452460
};
453-
cpu@1 {
461+
cpu1 {
454462
sound-dai = <&rcar_sound 2>;
455463
};
456-
cpu@2 {
464+
cpu2 {
457465
sound-dai = <&rcar_sound 3>;
458466
};
459-
cpu@3 {
467+
cpu3 {
460468
sound-dai = <&rcar_sound 4>;
461469
};
462470
codec {
@@ -468,6 +476,7 @@ examples:
468476
};
469477
470478
simple-audio-card,dai-link@2 {
479+
reg = <2>;
471480
format = "i2s";
472481
bitclock-master = <&sndcpu2>;
473482
frame-master = <&sndcpu2>;

0 commit comments

Comments
 (0)