Skip to content

Commit 5b05897

Browse files
roxelltsbogend
authored andcommitted
mips: lib: uncached: fix non-standard usage of variable 'sp'
When building mips tinyconfig with clang the following warning show up: arch/mips/lib/uncached.c:45:6: warning: variable 'sp' is uninitialized when used here [-Wuninitialized] if (sp >= (long)CKSEG0 && sp < (long)CKSEG2) ^~ arch/mips/lib/uncached.c:40:18: note: initialize the variable 'sp' to silence this warning register long sp __asm__("$sp"); ^ = 0 1 warning generated. Rework to make an explicit inline move, instead of the non-standard use of specifying registers for local variables. This is what's written from the gcc-10 manual [1] about specifying registers for local variables: "6.47.5.2 Specifying Registers for Local Variables ................................................. [...] "The only supported use for this feature is to specify registers for input and output operands when calling Extended 'asm' (*note Extended Asm::). [...]". [1] https://docs.w3cub.com/gcc~10/local-register-variables Signed-off-by: Anders Roxell <[email protected]> Reported-by: Nathan Chancellor <[email protected]> Reported-by: Naresh Kamboju <[email protected]> Reviewed-by: Nick Desaulniers <[email protected]> Signed-off-by: Thomas Bogendoerfer <[email protected]>
1 parent 991838f commit 5b05897

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

arch/mips/lib/uncached.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,12 @@
3737
*/
3838
unsigned long run_uncached(void *func)
3939
{
40-
register long sp __asm__("$sp");
4140
register long ret __asm__("$2");
4241
long lfunc = (long)func, ufunc;
4342
long usp;
43+
long sp;
44+
45+
__asm__("move %0, $sp" : "=r" (sp));
4446

4547
if (sp >= (long)CKSEG0 && sp < (long)CKSEG2)
4648
usp = CKSEG1ADDR(sp);

0 commit comments

Comments
 (0)