Skip to content

Commit 5b17a04

Browse files
gctuckerkrzk
authored andcommitted
ARM: exynos: clear L310_AUX_CTRL_FULL_LINE_ZERO in default l2c_aux_val
This "alert" error message can be seen on exynos4412-odroidx2: L2C: platform modifies aux control register: 0x02070000 -> 0x3e470001 L2C: platform provided aux values permit register corruption. Followed by this plain error message: L2C-310: enabling full line of zeros but not enabled in Cortex-A9 To fix it, don't set the L310_AUX_CTRL_FULL_LINE_ZERO flag (bit 0) in the default value of l2c_aux_val. It may instead be enabled when applicable by the logic in l2c310_enable() if the attribute "arm,full-line-zero-disable" was set in the device tree. The initial commit that introduced this default value was in v2.6.38 commit 1cf0eb7 ("ARM: S5PV310: Add L2 cache init function in cpu.c"). However, the code to set the L310_AUX_CTRL_FULL_LINE_ZERO flag and manage that feature was added much later and the default value was not updated then. So this seems to have been a subtle oversight especially since enabling it only in the cache and not in the A9 core doesn't actually prevent the platform from running. According to the TRM, the opposite would be a real issue, if the feature was enabled in the A9 core but not in the cache controller. Reported-by: "kernelci.org bot" <[email protected]> Signed-off-by: Guillaume Tucker <[email protected]> Signed-off-by: Krzysztof Kozlowski <[email protected]>
1 parent b3a9e3b commit 5b17a04

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/arm/mach-exynos/exynos.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ static void __init exynos_dt_fixup(void)
193193
}
194194

195195
DT_MACHINE_START(EXYNOS_DT, "Samsung Exynos (Flattened Device Tree)")
196-
.l2c_aux_val = 0x3c400001,
196+
.l2c_aux_val = 0x3c400000,
197197
.l2c_aux_mask = 0xc20fffff,
198198
.smp = smp_ops(exynos_smp_ops),
199199
.map_io = exynos_init_io,

0 commit comments

Comments
 (0)