Skip to content

Commit 5b38db0

Browse files
Andre-ARMWim Van Sebroeck
authored andcommitted
dt-bindings: watchdog: sunxi: clarify clock support
Most Allwinner SoCs have just one input clock to drive the watchdog peripheral. So far this is the 24 MHz "HOSC" oscillator, divided down internally to 32 KHz. The F1C100 series watchdog however uses the unchanged 32 KHz "LOSC" as its only clock input, which has the same effect, but let's the binding description mismatch. Change the binding description to name the clocks more loosely, so both the LOSC and divided HOSC match the description. As the fixed clock names now make less sense, drop them from SoCs supporting just one clock input, they were not used by any DT anyway. For the newer SoCs, supporting a choice of two input clocks, we keep both the description and clock-names requirement. Signed-off-by: Andre Przywara <[email protected]> Reviewed-by: Rob Herring <[email protected]> Reviewed-by: Samuel Holland <[email protected]> Reviewed-by: Guenter Roeck <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Guenter Roeck <[email protected]> Signed-off-by: Wim Van Sebroeck <[email protected]>
1 parent 70fabe2 commit 5b38db0

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,8 @@ properties:
3939
clocks:
4040
minItems: 1
4141
items:
42-
- description: High-frequency oscillator input, divided internally
43-
- description: Low-frequency oscillator input, only found on some variants
44-
45-
clock-names:
46-
minItems: 1
47-
items:
48-
- const: hosc
49-
- const: losc
42+
- description: 32 KHz input clock
43+
- description: secondary clock source
5044

5145
interrupts:
5246
maxItems: 1
@@ -71,9 +65,14 @@ then:
7165
properties:
7266
clocks:
7367
minItems: 2
68+
items:
69+
- description: High-frequency oscillator input, divided internally
70+
- description: Low-frequency oscillator input
7471

7572
clock-names:
76-
minItems: 2
73+
items:
74+
- const: hosc
75+
- const: losc
7776

7877
required:
7978
- clock-names
@@ -83,9 +82,6 @@ else:
8382
clocks:
8483
maxItems: 1
8584

86-
clock-names:
87-
maxItems: 1
88-
8985
unevaluatedProperties: false
9086

9187
examples:

0 commit comments

Comments
 (0)