Skip to content

Commit 5b65af8

Browse files
committed
firmware: arm_scmi: Use the term 'message' instead of 'command'
In preparation to adding support for other two types of messages that SCMI specification mentions, let's replace the term 'command' with the correct term 'message'. As per the specification the messages are of 3 types: commands(synchronous or asynchronous), delayed responses and notifications. Signed-off-by: Sudeep Holla <[email protected]>
1 parent c29a628 commit 5b65af8

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

drivers/firmware/arm_scmi/common.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,11 @@ struct scmi_msg_resp_prot_version {
4848
/**
4949
* struct scmi_msg_hdr - Message(Tx/Rx) header
5050
*
51-
* @id: The identifier of the command being sent
52-
* @protocol_id: The identifier of the protocol used to send @id command
53-
* @seq: The token to identify the message. when a message/command returns,
54-
* the platform returns the whole message header unmodified including
55-
* the token
51+
* @id: The identifier of the message being sent
52+
* @protocol_id: The identifier of the protocol used to send @id message
53+
* @seq: The token to identify the message. When a message returns, the
54+
* platform returns the whole message header unmodified including the
55+
* token
5656
* @status: Status of the transfer once it's complete
5757
* @poll_completion: Indicate if the transfer needs to be polled for
5858
* completion or interrupt mode is used

drivers/firmware/arm_scmi/driver.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ static inline int scmi_to_linux_errno(int errno)
182182
static inline void scmi_dump_header_dbg(struct device *dev,
183183
struct scmi_msg_hdr *hdr)
184184
{
185-
dev_dbg(dev, "Command ID: %x Sequence ID: %x Protocol: %x\n",
185+
dev_dbg(dev, "Message ID: %x Sequence ID: %x Protocol: %x\n",
186186
hdr->id, hdr->seq, hdr->protocol_id);
187187
}
188188

@@ -241,7 +241,7 @@ static void scmi_rx_callback(struct mbox_client *cl, void *m)
241241
* @hdr: pointer to header containing all the information on message id,
242242
* protocol id and sequence id.
243243
*
244-
* Return: 32-bit packed command header to be sent to the platform.
244+
* Return: 32-bit packed message header to be sent to the platform.
245245
*/
246246
static inline u32 pack_scmi_header(struct scmi_msg_hdr *hdr)
247247
{
@@ -280,7 +280,7 @@ static void scmi_tx_prepare(struct mbox_client *cl, void *m)
280280
*
281281
* @handle: Pointer to SCMI entity handle
282282
*
283-
* Helper function which is used by various command functions that are
283+
* Helper function which is used by various message functions that are
284284
* exposed to clients of this driver for allocating a message traffic event.
285285
*
286286
* This function can sleep depending on pending requests already in the system

0 commit comments

Comments
 (0)