fix a braino in legitimize_path()

Al Viro · Al Viro · commit 5bd73286d50f · 2020-04-06T10:38:59.000-04:00
brown paperbag time... wrong order of arguments ended up confusing the values to check dentry and mount_lock seqcounts against. Reported-by: kernel test robot <rong.a.chen@intel.com> Fixes: 2aa3847 ("non-RCU analogue of the previous commit") Tested-by: kernel test robot <rong.a.chen@intel.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
diff --git a/fs/namei.c b/fs/namei.c
@@ -610,7 +610,7 @@ static bool __legitimize_path(struct path *path, unsigned seq, unsigned mseq)
 static inline bool legitimize_path(struct nameidata *nd,
 			    struct path *path, unsigned seq)
 {
-	return __legitimize_path(path, nd->m_seq, seq);
+	return __legitimize_path(path, seq, nd->m_seq);
 }
 
 static bool legitimize_links(struct nameidata *nd)

Original file line number	Diff line number	Diff line change
`@@ -610,7 +610,7 @@ static bool __legitimize_path(struct path *path, unsigned seq, unsigned mseq)`
`610`	`610`	`static inline bool legitimize_path(struct nameidata *nd,`
`611`	`611`	`struct path *path, unsigned seq)`
`612`	`612`	`{`
`613`		`- return __legitimize_path(path, nd->m_seq, seq);`
	`613`	`+ return __legitimize_path(path, seq, nd->m_seq);`
`614`	`614`	`}`
`615`	`615`
`616`	`616`	`static bool legitimize_links(struct nameidata *nd)`