Skip to content

Commit 5bfc4a3

Browse files
btw616jmberg-intel
authored andcommitted
um: Remove obsolete fixmap support
It was added to support highmem. But since the highmem support has been removed by commit a98a6d8 ("um: Remove broken highmem support"), it is no longer needed. Remove it to simplify the code. Signed-off-by: Tiwei Bie <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Johannes Berg <[email protected]>
1 parent aa36314 commit 5bfc4a3

File tree

3 files changed

+5
-71
lines changed

3 files changed

+5
-71
lines changed

arch/um/include/asm/fixmap.h

Lines changed: 0 additions & 56 deletions
This file was deleted.

arch/um/include/asm/pgtable.h

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88
#ifndef __UM_PGTABLE_H
99
#define __UM_PGTABLE_H
1010

11-
#include <asm/fixmap.h>
12-
1311
#define _PAGE_PRESENT 0x001
1412
#define _PAGE_NEEDSYNC 0x002
1513
#define _PAGE_RW 0x020
@@ -48,8 +46,7 @@ extern unsigned long end_iomem;
4846

4947
#define VMALLOC_OFFSET (__va_space)
5048
#define VMALLOC_START ((end_iomem + VMALLOC_OFFSET) & ~(VMALLOC_OFFSET-1))
51-
#define PKMAP_BASE ((FIXADDR_START - LAST_PKMAP * PAGE_SIZE) & PMD_MASK)
52-
#define VMALLOC_END (FIXADDR_START-2*PAGE_SIZE)
49+
#define VMALLOC_END (TASK_SIZE-2*PAGE_SIZE)
5350
#define MODULES_VADDR VMALLOC_START
5451
#define MODULES_END VMALLOC_END
5552

arch/um/kernel/mem.c

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#include <linux/mm.h>
1010
#include <linux/swap.h>
1111
#include <linux/slab.h>
12-
#include <asm/fixmap.h>
1312
#include <asm/page.h>
1413
#include <asm/pgalloc.h>
1514
#include <as-layout.h>
@@ -74,6 +73,7 @@ void __init mem_init(void)
7473
kmalloc_ok = 1;
7574
}
7675

76+
#if IS_ENABLED(CONFIG_ARCH_REUSE_HOST_VSYSCALL_AREA)
7777
/*
7878
* Create a page table and place a pointer to it in a middle page
7979
* directory entry.
@@ -152,7 +152,6 @@ static void __init fixrange_init(unsigned long start, unsigned long end,
152152

153153
static void __init fixaddr_user_init( void)
154154
{
155-
#ifdef CONFIG_ARCH_REUSE_HOST_VSYSCALL_AREA
156155
long size = FIXADDR_USER_END - FIXADDR_USER_START;
157156
pte_t *pte;
158157
phys_t p;
@@ -174,13 +173,12 @@ static void __init fixaddr_user_init( void)
174173
pte = virt_to_kpte(vaddr);
175174
pte_set_val(*pte, p, PAGE_READONLY);
176175
}
177-
#endif
178176
}
177+
#endif
179178

180179
void __init paging_init(void)
181180
{
182181
unsigned long max_zone_pfn[MAX_NR_ZONES] = { 0 };
183-
unsigned long vaddr;
184182

185183
empty_zero_page = (unsigned long *) memblock_alloc_low(PAGE_SIZE,
186184
PAGE_SIZE);
@@ -191,14 +189,9 @@ void __init paging_init(void)
191189
max_zone_pfn[ZONE_NORMAL] = end_iomem >> PAGE_SHIFT;
192190
free_area_init(max_zone_pfn);
193191

194-
/*
195-
* Fixed mappings, only the page table structure has to be
196-
* created - mappings will be set by set_fixmap():
197-
*/
198-
vaddr = __fix_to_virt(__end_of_fixed_addresses - 1) & PMD_MASK;
199-
fixrange_init(vaddr, FIXADDR_TOP, swapper_pg_dir);
200-
192+
#if IS_ENABLED(CONFIG_ARCH_REUSE_HOST_VSYSCALL_AREA)
201193
fixaddr_user_init();
194+
#endif
202195
}
203196

204197
/*

0 commit comments

Comments
 (0)