Skip to content

Commit 5c0cd3d

Browse files
committed
Merge tag 'fs_for_v5.19-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs
Pull writeback and ext2 fixes from Jan Kara: "A fix for writeback bug which prevented machines with kdevtmpfs from booting and also one small ext2 bugfix in IO error handling" * tag 'fs_for_v5.19-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs: init: Initialize noop_backing_dev_info early ext2: fix fs corruption when trying to remove a non-empty directory with IO error
2 parents 274295c + 4bca7e8 commit 5c0cd3d

File tree

4 files changed

+9
-15
lines changed

4 files changed

+9
-15
lines changed

drivers/base/init.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
#include <linux/init.h>
99
#include <linux/memory.h>
1010
#include <linux/of.h>
11+
#include <linux/backing-dev.h>
1112

1213
#include "base.h"
1314

@@ -20,6 +21,7 @@
2021
void __init driver_init(void)
2122
{
2223
/* These are the core pieces */
24+
bdi_init(&noop_backing_dev_info);
2325
devtmpfs_init();
2426
devices_init();
2527
buses_init();

fs/ext2/dir.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -672,17 +672,14 @@ int ext2_empty_dir (struct inode * inode)
672672
void *page_addr = NULL;
673673
struct page *page = NULL;
674674
unsigned long i, npages = dir_pages(inode);
675-
int dir_has_error = 0;
676675

677676
for (i = 0; i < npages; i++) {
678677
char *kaddr;
679678
ext2_dirent * de;
680-
page = ext2_get_page(inode, i, dir_has_error, &page_addr);
679+
page = ext2_get_page(inode, i, 0, &page_addr);
681680

682-
if (IS_ERR(page)) {
683-
dir_has_error = 1;
684-
continue;
685-
}
681+
if (IS_ERR(page))
682+
goto not_empty;
686683

687684
kaddr = page_addr;
688685
de = (ext2_dirent *)kaddr;

include/linux/backing-dev.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,8 @@ int bdi_set_max_ratio(struct backing_dev_info *bdi, unsigned int max_ratio);
119119

120120
extern struct backing_dev_info noop_backing_dev_info;
121121

122+
int bdi_init(struct backing_dev_info *bdi);
123+
122124
/**
123125
* writeback_in_progress - determine whether there is writeback in progress
124126
* @wb: bdi_writeback of interest

mm/backing-dev.c

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -231,20 +231,13 @@ static __init int bdi_class_init(void)
231231
}
232232
postcore_initcall(bdi_class_init);
233233

234-
static int bdi_init(struct backing_dev_info *bdi);
235-
236234
static int __init default_bdi_init(void)
237235
{
238-
int err;
239-
240236
bdi_wq = alloc_workqueue("writeback", WQ_MEM_RECLAIM | WQ_UNBOUND |
241237
WQ_SYSFS, 0);
242238
if (!bdi_wq)
243239
return -ENOMEM;
244-
245-
err = bdi_init(&noop_backing_dev_info);
246-
247-
return err;
240+
return 0;
248241
}
249242
subsys_initcall(default_bdi_init);
250243

@@ -781,7 +774,7 @@ static void cgwb_remove_from_bdi_list(struct bdi_writeback *wb)
781774

782775
#endif /* CONFIG_CGROUP_WRITEBACK */
783776

784-
static int bdi_init(struct backing_dev_info *bdi)
777+
int bdi_init(struct backing_dev_info *bdi)
785778
{
786779
int ret;
787780

0 commit comments

Comments
 (0)