Skip to content

Commit 5c16f7e

Browse files
author
Ingo Molnar
committed
Merge branch 'x86/urgent' into x86/sgx, to resolve conflict
Conflicts: arch/x86/kernel/cpu/sgx/main.c Signed-off-by: Ingo Molnar <[email protected]>
2 parents 379e4de + ac5d272 commit 5c16f7e

File tree

2 files changed

+45
-33
lines changed

2 files changed

+45
-33
lines changed

arch/x86/kernel/cpu/sgx/main.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@ static DEFINE_XARRAY(sgx_epc_address_space);
2929
static LIST_HEAD(sgx_active_page_list);
3030
static DEFINE_SPINLOCK(sgx_reclaimer_lock);
3131

32-
/* The free page list lock protected variables prepend the lock. */
33-
static unsigned long sgx_nr_free_pages;
32+
static atomic_long_t sgx_nr_free_pages = ATOMIC_LONG_INIT(0);
3433

3534
/* Nodes with one or more EPC sections. */
3635
static nodemask_t sgx_numa_mask;
@@ -422,14 +421,15 @@ static void sgx_reclaim_pages(void)
422421

423422
spin_lock(&node->lock);
424423
list_add_tail(&epc_page->list, &node->free_page_list);
425-
sgx_nr_free_pages++;
426424
spin_unlock(&node->lock);
425+
atomic_long_inc(&sgx_nr_free_pages);
427426
}
428427
}
429428

430429
static bool sgx_should_reclaim(unsigned long watermark)
431430
{
432-
return sgx_nr_free_pages < watermark && !list_empty(&sgx_active_page_list);
431+
return atomic_long_read(&sgx_nr_free_pages) < watermark &&
432+
!list_empty(&sgx_active_page_list);
433433
}
434434

435435
static int ksgxd(void *p)
@@ -490,10 +490,10 @@ static struct sgx_epc_page *__sgx_alloc_epc_page_from_node(int nid)
490490

491491
page = list_first_entry(&node->free_page_list, struct sgx_epc_page, list);
492492
list_del_init(&page->list);
493-
sgx_nr_free_pages--;
494493
page->flags = 0;
495494

496495
spin_unlock(&node->lock);
496+
atomic_long_dec(&sgx_nr_free_pages);
497497

498498
return page;
499499
}
@@ -649,10 +649,10 @@ void sgx_free_epc_page(struct sgx_epc_page *page)
649649
list_add(&page->list, &node->sgx_poison_page_list);
650650
else
651651
list_add_tail(&page->list, &node->free_page_list);
652-
sgx_nr_free_pages++;
653652
page->flags = SGX_EPC_PAGE_IS_FREE;
654653

655654
spin_unlock(&node->lock);
655+
atomic_long_inc(&sgx_nr_free_pages);
656656
}
657657

658658
static bool __init sgx_setup_epc_section(u64 phys_addr, u64 size,

arch/x86/kernel/setup.c

Lines changed: 39 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -742,6 +742,28 @@ dump_kernel_offset(struct notifier_block *self, unsigned long v, void *p)
742742
return 0;
743743
}
744744

745+
static char *prepare_command_line(void)
746+
{
747+
#ifdef CONFIG_CMDLINE_BOOL
748+
#ifdef CONFIG_CMDLINE_OVERRIDE
749+
strlcpy(boot_command_line, builtin_cmdline, COMMAND_LINE_SIZE);
750+
#else
751+
if (builtin_cmdline[0]) {
752+
/* append boot loader cmdline to builtin */
753+
strlcat(builtin_cmdline, " ", COMMAND_LINE_SIZE);
754+
strlcat(builtin_cmdline, boot_command_line, COMMAND_LINE_SIZE);
755+
strlcpy(boot_command_line, builtin_cmdline, COMMAND_LINE_SIZE);
756+
}
757+
#endif
758+
#endif
759+
760+
strlcpy(command_line, boot_command_line, COMMAND_LINE_SIZE);
761+
762+
parse_early_param();
763+
764+
return command_line;
765+
}
766+
745767
/*
746768
* Determine if we were loaded by an EFI loader. If so, then we have also been
747769
* passed the efi memmap, systab, etc., so we should use these data structures
@@ -830,6 +852,23 @@ void __init setup_arch(char **cmdline_p)
830852

831853
x86_init.oem.arch_setup();
832854

855+
/*
856+
* x86_configure_nx() is called before parse_early_param() (called by
857+
* prepare_command_line()) to detect whether hardware doesn't support
858+
* NX (so that the early EHCI debug console setup can safely call
859+
* set_fixmap()). It may then be called again from within noexec_setup()
860+
* during parsing early parameters to honor the respective command line
861+
* option.
862+
*/
863+
x86_configure_nx();
864+
865+
/*
866+
* This parses early params and it needs to run before
867+
* early_reserve_memory() because latter relies on such settings
868+
* supplied as early params.
869+
*/
870+
*cmdline_p = prepare_command_line();
871+
833872
/*
834873
* Do some memory reservations *before* memory is added to memblock, so
835874
* memblock allocations won't overwrite it.
@@ -863,33 +902,6 @@ void __init setup_arch(char **cmdline_p)
863902
bss_resource.start = __pa_symbol(__bss_start);
864903
bss_resource.end = __pa_symbol(__bss_stop)-1;
865904

866-
#ifdef CONFIG_CMDLINE_BOOL
867-
#ifdef CONFIG_CMDLINE_OVERRIDE
868-
strlcpy(boot_command_line, builtin_cmdline, COMMAND_LINE_SIZE);
869-
#else
870-
if (builtin_cmdline[0]) {
871-
/* append boot loader cmdline to builtin */
872-
strlcat(builtin_cmdline, " ", COMMAND_LINE_SIZE);
873-
strlcat(builtin_cmdline, boot_command_line, COMMAND_LINE_SIZE);
874-
strlcpy(boot_command_line, builtin_cmdline, COMMAND_LINE_SIZE);
875-
}
876-
#endif
877-
#endif
878-
879-
strlcpy(command_line, boot_command_line, COMMAND_LINE_SIZE);
880-
*cmdline_p = command_line;
881-
882-
/*
883-
* x86_configure_nx() is called before parse_early_param() to detect
884-
* whether hardware doesn't support NX (so that the early EHCI debug
885-
* console setup can safely call set_fixmap()). It may then be called
886-
* again from within noexec_setup() during parsing early parameters
887-
* to honor the respective command line option.
888-
*/
889-
x86_configure_nx();
890-
891-
parse_early_param();
892-
893905
#ifdef CONFIG_MEMORY_HOTPLUG
894906
/*
895907
* Memory used by the kernel cannot be hot-removed because Linux

0 commit comments

Comments
 (0)