Skip to content

Commit 5c1f33e

Browse files
jmberg-intelrichardweinberger
authored andcommitted
um: Don't trace irqflags during shutdown
In the main() code, we eventually enable signals just before exec() or exit(), in order to to not have signals pending and delivered *after* the exec(). I've observed SIGSEGV loops at this point, and the reason seems to be the irqflags tracing; this makes sense as the kernel is no longer really functional at this point. Since there's really no reason to use unblock_signals_trace() here (I had just done a global search & replace), use the plain unblock_signals() in this case to avoid going into the no longer functional kernel. Fixes: 0dafcbe ("um: Implement TRACE_IRQFLAGS_SUPPORT") Signed-off-by: Johannes Berg <[email protected]> Signed-off-by: Richard Weinberger <[email protected]>
1 parent e472c64 commit 5c1f33e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/um/os-Linux/main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ int __init main(int argc, char **argv, char **envp)
170170
* that they won't be delivered after the exec, when
171171
* they are definitely not expected.
172172
*/
173-
unblock_signals_trace();
173+
unblock_signals();
174174

175175
os_info("\n");
176176
/* Reboot */

0 commit comments

Comments
 (0)