Skip to content

Commit 5c23878

Browse files
javiercarrascocruzsuperna9999
authored andcommitted
drm/bridge: tc358767: fix missing of_node_put() in for_each_endpoint_of_node()
for_each_endpoint_of_node() requires a call to of_node_put() for every early exit. A new error path was added to the loop without observing this requirement. Add the missing call to of_node_put() in the error path. Fixes: 1fb4dce ("drm/bridge: tc358767: Add configurable default preemphasis") Signed-off-by: Javier Carrasco <[email protected]> Reviewed-by: Marek Vasut <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Neil Armstrong <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 85e444a commit 5c23878

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/gpu/drm/bridge/tc358767.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2391,6 +2391,7 @@ static int tc_probe_bridge_endpoint(struct tc_data *tc)
23912391
if (tc->pre_emphasis[0] < 0 || tc->pre_emphasis[0] > 2 ||
23922392
tc->pre_emphasis[1] < 0 || tc->pre_emphasis[1] > 2) {
23932393
dev_err(dev, "Incorrect Pre-Emphasis setting, use either 0=0dB 1=3.5dB 2=6dB\n");
2394+
of_node_put(node);
23942395
return -EINVAL;
23952396
}
23962397
}

0 commit comments

Comments
 (0)