Skip to content

Commit 5c4e1d1

Browse files
michichkuba-moo
authored andcommitted
iavf: use unregister_netdev
Use unregister_netdev, which takes rtnl_lock for us. We don't have to check the reg_state under rtnl_lock. There's nothing to race with. We have just cancelled the finish_config work. Signed-off-by: Michal Schmidt <[email protected]> Reviewed-by: Wojciech Drewek <[email protected]> Reviewed-by: Jacob Keller <[email protected]> Signed-off-by: Jacob Keller <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 34ad34b commit 5c4e1d1

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/net/ethernet/intel/iavf/iavf_main.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5167,10 +5167,8 @@ static void iavf_remove(struct pci_dev *pdev)
51675167
cancel_delayed_work_sync(&adapter->watchdog_task);
51685168
cancel_work_sync(&adapter->finish_config);
51695169

5170-
rtnl_lock();
51715170
if (netdev->reg_state == NETREG_REGISTERED)
5172-
unregister_netdevice(netdev);
5173-
rtnl_unlock();
5171+
unregister_netdev(netdev);
51745172

51755173
if (CLIENT_ALLOWED(adapter)) {
51765174
err = iavf_lan_del_device(adapter);

0 commit comments

Comments
 (0)