Skip to content

Commit 5c6fb4b

Browse files
LyudeBen Skeggs
authored andcommitted
drm/nouveau/kms/nv50-: Use atomic encoder callbacks everywhere
It turns out that I forgot to go through and make sure that I converted all encoder callbacks to use atomic_enable/atomic_disable(), so let's go and actually do that. Signed-off-by: Lyude Paul <[email protected]> Cc: Kirill A. Shutemov <[email protected]> Fixes: 09838c4 ("drm/nouveau/kms: Search for encoders' connectors properly") Signed-off-by: Ben Skeggs <[email protected]>
1 parent 6c27ffa commit 5c6fb4b

File tree

1 file changed

+14
-15
lines changed
  • drivers/gpu/drm/nouveau/dispnv50

1 file changed

+14
-15
lines changed

drivers/gpu/drm/nouveau/dispnv50/disp.c

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,7 @@ nv50_outp_get_old_connector(struct nouveau_encoder *outp,
455455
* DAC
456456
*****************************************************************************/
457457
static void
458-
nv50_dac_disable(struct drm_encoder *encoder)
458+
nv50_dac_disable(struct drm_encoder *encoder, struct drm_atomic_state *state)
459459
{
460460
struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
461461
struct nv50_core *core = nv50_disp(encoder->dev)->core;
@@ -467,7 +467,7 @@ nv50_dac_disable(struct drm_encoder *encoder)
467467
}
468468

469469
static void
470-
nv50_dac_enable(struct drm_encoder *encoder)
470+
nv50_dac_enable(struct drm_encoder *encoder, struct drm_atomic_state *state)
471471
{
472472
struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
473473
struct nouveau_crtc *nv_crtc = nouveau_crtc(encoder->crtc);
@@ -525,8 +525,8 @@ nv50_dac_detect(struct drm_encoder *encoder, struct drm_connector *connector)
525525
static const struct drm_encoder_helper_funcs
526526
nv50_dac_help = {
527527
.atomic_check = nv50_outp_atomic_check,
528-
.enable = nv50_dac_enable,
529-
.disable = nv50_dac_disable,
528+
.atomic_enable = nv50_dac_enable,
529+
.atomic_disable = nv50_dac_disable,
530530
.detect = nv50_dac_detect
531531
};
532532

@@ -1055,7 +1055,7 @@ nv50_dp_bpc_to_depth(unsigned int bpc)
10551055
}
10561056

10571057
static void
1058-
nv50_msto_enable(struct drm_encoder *encoder)
1058+
nv50_msto_enable(struct drm_encoder *encoder, struct drm_atomic_state *state)
10591059
{
10601060
struct nv50_head *head = nv50_head(encoder->crtc);
10611061
struct nv50_head_atom *armh = nv50_head_atom(head->base.base.state);
@@ -1101,7 +1101,7 @@ nv50_msto_enable(struct drm_encoder *encoder)
11011101
}
11021102

11031103
static void
1104-
nv50_msto_disable(struct drm_encoder *encoder)
1104+
nv50_msto_disable(struct drm_encoder *encoder, struct drm_atomic_state *state)
11051105
{
11061106
struct nv50_msto *msto = nv50_msto(encoder);
11071107
struct nv50_mstc *mstc = msto->mstc;
@@ -1118,8 +1118,8 @@ nv50_msto_disable(struct drm_encoder *encoder)
11181118

11191119
static const struct drm_encoder_helper_funcs
11201120
nv50_msto_help = {
1121-
.disable = nv50_msto_disable,
1122-
.enable = nv50_msto_enable,
1121+
.atomic_disable = nv50_msto_disable,
1122+
.atomic_enable = nv50_msto_enable,
11231123
.atomic_check = nv50_msto_atomic_check,
11241124
};
11251125

@@ -1645,8 +1645,7 @@ nv50_sor_disable(struct drm_encoder *encoder,
16451645
}
16461646

16471647
static void
1648-
nv50_sor_enable(struct drm_encoder *encoder,
1649-
struct drm_atomic_state *state)
1648+
nv50_sor_enable(struct drm_encoder *encoder, struct drm_atomic_state *state)
16501649
{
16511650
struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
16521651
struct nouveau_crtc *nv_crtc = nouveau_crtc(encoder->crtc);
@@ -1873,7 +1872,7 @@ nv50_pior_atomic_check(struct drm_encoder *encoder,
18731872
}
18741873

18751874
static void
1876-
nv50_pior_disable(struct drm_encoder *encoder)
1875+
nv50_pior_disable(struct drm_encoder *encoder, struct drm_atomic_state *state)
18771876
{
18781877
struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
18791878
struct nv50_core *core = nv50_disp(encoder->dev)->core;
@@ -1885,7 +1884,7 @@ nv50_pior_disable(struct drm_encoder *encoder)
18851884
}
18861885

18871886
static void
1888-
nv50_pior_enable(struct drm_encoder *encoder)
1887+
nv50_pior_enable(struct drm_encoder *encoder, struct drm_atomic_state *state)
18891888
{
18901889
struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
18911890
struct nouveau_crtc *nv_crtc = nouveau_crtc(encoder->crtc);
@@ -1921,14 +1920,14 @@ nv50_pior_enable(struct drm_encoder *encoder)
19211920
}
19221921

19231922
core->func->pior->ctrl(core, nv_encoder->or, ctrl, asyh);
1924-
nv_encoder->crtc = encoder->crtc;
1923+
nv_encoder->crtc = &nv_crtc->base;
19251924
}
19261925

19271926
static const struct drm_encoder_helper_funcs
19281927
nv50_pior_help = {
19291928
.atomic_check = nv50_pior_atomic_check,
1930-
.enable = nv50_pior_enable,
1931-
.disable = nv50_pior_disable,
1929+
.atomic_enable = nv50_pior_enable,
1930+
.atomic_disable = nv50_pior_disable,
19321931
};
19331932

19341933
static void

0 commit comments

Comments
 (0)