Skip to content

Commit 5c81691

Browse files
akiyksJonathan Corbet
authored andcommitted
docs: admin-guide/blockdev: Remove digraph of node-states
While node-states-8.dot has two digraphs, the dot(1) command can not properly handle multiple graphs in a DOT file and the kernel-doc page at https://www.kernel.org/doc/html/latest/admin-guide/blockdev/drbd/figures.html fails to render the graphs. It turned out that the digraph of node_states can be removed. Quote from Joel's reflection: On reflection, the digraph node_states can be removed entirely. It is too basic to contain any useful information. In addition it references "ioctl_set_state". The ioctl configuration interface for DRBD has long been removed. In fact, it was never in the upstream version of DRBD. Remove node_states and rename the DOT file peer_states-8.dot. Suggested-by: Joel Colledge <[email protected]> Acked-by: Joel Colledge <[email protected]> Signed-off-by: Akira Yokosawa <[email protected]> Cc: Philipp Reisner <[email protected]> Cc: Lars Ellenberg <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jonathan Corbet <[email protected]>
1 parent d69dab7 commit 5c81691

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

Documentation/admin-guide/blockdev/drbd/figures.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,6 @@ Sub graphs of DRBD's state transitions
2525
:alt: disk-states-8.dot
2626
:align: center
2727

28-
.. kernel-figure:: node-states-8.dot
29-
:alt: node-states-8.dot
28+
.. kernel-figure:: peer-states-8.dot
29+
:alt: peer-states-8.dot
3030
:align: center

Documentation/admin-guide/blockdev/drbd/node-states-8.dot renamed to Documentation/admin-guide/blockdev/drbd/peer-states-8.dot

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,3 @@
1-
digraph node_states {
2-
Secondary -> Primary [ label = "ioctl_set_state()" ]
3-
Primary -> Secondary [ label = "ioctl_set_state()" ]
4-
}
5-
61
digraph peer_states {
72
Secondary -> Primary [ label = "recv state packet" ]
83
Primary -> Secondary [ label = "recv state packet" ]

0 commit comments

Comments
 (0)