Skip to content

Commit 5c8764f

Browse files
chaseyuJaegeuk Kim
authored andcommitted
f2fs: fix to force buffered IO on inline_data inode
It will return all zero data when DIO reading from inline_data inode, it is because f2fs_iomap_begin() assign iomap->type w/ IOMAP_HOLE incorrectly for this case. We can let iomap framework handle inline data via assigning iomap->type and iomap->inline_data correctly, however, it will be a little bit complicated when handling race case in between direct IO and buffered IO. So, let's force to use buffered IO to fix this issue. Cc: [email protected] Reported-by: Barry Song <[email protected]> Signed-off-by: Chao Yu <[email protected]> Signed-off-by: Jaegeuk Kim <[email protected]>
1 parent 6924c8b commit 5c8764f

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

fs/f2fs/file.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -825,6 +825,8 @@ static bool f2fs_force_buffered_io(struct inode *inode, int rw)
825825
return true;
826826
if (f2fs_compressed_file(inode))
827827
return true;
828+
if (f2fs_has_inline_data(inode))
829+
return true;
828830

829831
/* disallow direct IO if any of devices has unaligned blksize */
830832
if (f2fs_is_multi_device(sbi) && !sbi->aligned_blksize)

0 commit comments

Comments
 (0)