Skip to content

Commit 5c8cf16

Browse files
chewittsuperna9999
authored andcommitted
drm/meson: fix 1px pink line on GXM when scaling video overlay
Playing media with a resolution smaller than the crtc size requires the video overlay to be scaled for output and GXM boards display a 1px pink line on the bottom of the scaled overlay. Comparing with the downstream vendor driver revealed VPP_DUMMY_DATA not being set [0]. Setting VPP_DUMMY_DATA prevents the 1px pink line from being seen. [0] https://github.com/endlessm/linux-s905x/blob/master/drivers/amlogic/amports/video.c#L7869 Fixes: bbbe775 ("drm: Add support for Amlogic Meson Graphic Controller") Suggested-by: Martin Blumenstingl <[email protected]> Signed-off-by: Christian Hewitt <[email protected]> Acked-by: Martin Blumenstingl <[email protected]> Signed-off-by: Neil Armstrong <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 4d8457f commit 5c8cf16

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/gpu/drm/meson/meson_vpp.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,8 @@ void meson_vpp_init(struct meson_drm *priv)
100100
priv->io_base + _REG(VPP_DOLBY_CTRL));
101101
writel_relaxed(0x1020080,
102102
priv->io_base + _REG(VPP_DUMMY_DATA1));
103+
writel_relaxed(0x42020,
104+
priv->io_base + _REG(VPP_DUMMY_DATA));
103105
} else if (meson_vpu_is_compatible(priv, VPU_COMPATIBLE_G12A))
104106
writel_relaxed(0xf, priv->io_base + _REG(DOLBY_PATH_CTRL));
105107

0 commit comments

Comments
 (0)