Skip to content

Commit 5c8f9a0

Browse files
shcgitmmind
authored andcommitted
arm64: dts: rockchip: Fix broken tsadc pinctrl names for rk3588
The tsadc driver does not handle pinctrl "gpio" and "otpout". Let's use the correct pinctrl names "default" and "sleep". Additionally, Alexey Charkov's testing [1] has established that it is necessary for pinctrl state to reference the &tsadc_shut_org configuration rather than &tsadc_shut for the driver to function correctly. [1] https://lkml.org/lkml/2025/1/24/966 Fixes: 32641b8 ("arm64: dts: rockchip: add rk3588 thermal sensor") Cc: [email protected] Reviewed-by: Dragan Simic <[email protected]> Signed-off-by: Alexander Shiyan <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Heiko Stuebner <[email protected]>
1 parent 2014c95 commit 5c8f9a0

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

arch/arm64/boot/dts/rockchip/rk3588-base.dtsi

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2668,9 +2668,9 @@
26682668
rockchip,hw-tshut-temp = <120000>;
26692669
rockchip,hw-tshut-mode = <0>; /* tshut mode 0:CRU 1:GPIO */
26702670
rockchip,hw-tshut-polarity = <0>; /* tshut polarity 0:LOW 1:HIGH */
2671-
pinctrl-0 = <&tsadc_gpio_func>;
2672-
pinctrl-1 = <&tsadc_shut>;
2673-
pinctrl-names = "gpio", "otpout";
2671+
pinctrl-0 = <&tsadc_shut_org>;
2672+
pinctrl-1 = <&tsadc_gpio_func>;
2673+
pinctrl-names = "default", "sleep";
26742674
#thermal-sensor-cells = <1>;
26752675
status = "disabled";
26762676
};

0 commit comments

Comments
 (0)