Skip to content

Commit 5cd3167

Browse files
tititiou36martinkpetersen
authored andcommitted
scsi: target: tcmu: Constify some structures
'struct nla_policy' and 'struct match_table_t' are not modified in this driver. Constifying these structures moves some data to a read-only section, so increase overall security, especially when the structure holds some function pointers, which is the case of struct nla_policy. On a x86_64, with allmodconfig: Before: ====== text data bss dec hex filename 93188 6933 338 100459 1886b drivers/target/target_core_user.o After: ===== text data bss dec hex filename 93508 6581 338 100427 1884b drivers/target/target_core_user.o Signed-off-by: Christophe JAILLET <[email protected]> Link: https://lore.kernel.org/r/f83cd8469cc17391178e1181e8c26c4c1fb6028f.1731330634.git.christophe.jaillet@wanadoo.fr Reviewed-by: Bodo Stroesser <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent 50740f4 commit 5cd3167

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/target/target_core_user.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ static const struct genl_multicast_group tcmu_mcgrps[] = {
361361
[TCMU_MCGRP_CONFIG] = { .name = "config", },
362362
};
363363

364-
static struct nla_policy tcmu_attr_policy[TCMU_ATTR_MAX+1] = {
364+
static const struct nla_policy tcmu_attr_policy[TCMU_ATTR_MAX + 1] = {
365365
[TCMU_ATTR_DEVICE] = { .type = NLA_STRING },
366366
[TCMU_ATTR_MINOR] = { .type = NLA_U32 },
367367
[TCMU_ATTR_CMD_STATUS] = { .type = NLA_S32 },
@@ -2430,7 +2430,7 @@ enum {
24302430
Opt_cmd_ring_size_mb, Opt_err,
24312431
};
24322432

2433-
static match_table_t tokens = {
2433+
static const match_table_t tokens = {
24342434
{Opt_dev_config, "dev_config=%s"},
24352435
{Opt_dev_size, "dev_size=%s"},
24362436
{Opt_hw_block_size, "hw_block_size=%d"},

0 commit comments

Comments
 (0)