Skip to content

Commit 5d1c70b

Browse files
PhilipYangAalexdeucher
authored andcommitted
drm/amdgpu: Increase hmm range get pages timeout
If hmm_range_fault returns -EBUSY, we should call hmm_range_fault again to validate the remaining pages. On one system with NUMA auto balancing enabled, hmm_range_fault takes 6 seconds for 1GB range because CPU migrate the range one page at a time. To be safe, increase timeout value to 1 second for 128MB range. Signed-off-by: Philip Yang <[email protected]> Reviewed-by: Felix Kuehling <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent d728eda commit 5d1c70b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/amd/amdgpu/amdgpu_hmm.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,8 +190,8 @@ int amdgpu_hmm_range_get_pages(struct mmu_interval_notifier *notifier,
190190
pr_debug("hmm range: start = 0x%lx, end = 0x%lx",
191191
hmm_range->start, hmm_range->end);
192192

193-
/* Assuming 512MB takes maxmium 1 second to fault page address */
194-
timeout = max((hmm_range->end - hmm_range->start) >> 29, 1UL);
193+
/* Assuming 128MB takes maximum 1 second to fault page address */
194+
timeout = max((hmm_range->end - hmm_range->start) >> 27, 1UL);
195195
timeout *= HMM_RANGE_DEFAULT_TIMEOUT;
196196
timeout = jiffies + msecs_to_jiffies(timeout);
197197

0 commit comments

Comments
 (0)