gfs2: Fix error handling in init_statfs

Andreas Gruenbacher · Andreas Gruenbacher · commit 5d49d3508b3c · 2021-06-28T14:30:00.000+02:00
On an error path, init_statfs calls iput(pn) after pn has already been put. Fix that by setting pn to NULL after the initial iput. Fixes: 97fd734 ("gfs2: lookup local statfs inodes prior to journal recovery") Cc: stable@vger.kernel.org # v5.10+ Reported-by: Jing Xiangfeng <jingxiangfeng@huawei.com> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
@@ -687,6 +687,7 @@ static int init_statfs(struct gfs2_sbd *sdp)
 	}
 
 	iput(pn);
+	pn = NULL;
 	ip = GFS2_I(sdp->sd_sc_inode);
 	error = gfs2_glock_nq_init(ip->i_gl, LM_ST_EXCLUSIVE, 0,
 				   &sdp->sd_sc_gh);

Original file line number	Diff line number	Diff line change
`@@ -687,6 +687,7 @@ static int init_statfs(struct gfs2_sbd *sdp)`
`687`	`687`	`}`
`688`	`688`
`689`	`689`	`iput(pn);`
	`690`	`+ pn = NULL;`
`690`	`691`	`ip = GFS2_I(sdp->sd_sc_inode);`
`691`	`692`	`error = gfs2_glock_nq_init(ip->i_gl, LM_ST_EXCLUSIVE, 0,`
`692`	`693`	`&sdp->sd_sc_gh);`