Skip to content

Commit 5d90492

Browse files
oleremdavem330
authored andcommitted
net: dsa: microchip: ksz8: fix ksz8_fdb_dump() to extract all 1024 entries
Current ksz8_fdb_dump() is able to extract only max 249 entries on the ksz8863/ksz8873 series of switches. This happened due to wrong bit mask and offset calculation. This commit corrects the issue and allows for the complete extraction of all 1024 entries. Fixes: 4b20a07 ("net: dsa: microchip: ksz8795: add support for ksz88xx chips") Signed-off-by: Oleksij Rempel <[email protected]> Acked-by: Arun Ramadoss <[email protected]> Reviewed-by: Florian Fainelli <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 88e943e commit 5d90492

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/net/dsa/microchip/ksz_common.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -407,10 +407,10 @@ static const u32 ksz8863_masks[] = {
407407
[STATIC_MAC_TABLE_FID] = GENMASK(29, 26),
408408
[STATIC_MAC_TABLE_OVERRIDE] = BIT(20),
409409
[STATIC_MAC_TABLE_FWD_PORTS] = GENMASK(18, 16),
410-
[DYNAMIC_MAC_TABLE_ENTRIES_H] = GENMASK(5, 0),
410+
[DYNAMIC_MAC_TABLE_ENTRIES_H] = GENMASK(1, 0),
411411
[DYNAMIC_MAC_TABLE_MAC_EMPTY] = BIT(7),
412412
[DYNAMIC_MAC_TABLE_NOT_READY] = BIT(7),
413-
[DYNAMIC_MAC_TABLE_ENTRIES] = GENMASK(31, 28),
413+
[DYNAMIC_MAC_TABLE_ENTRIES] = GENMASK(31, 24),
414414
[DYNAMIC_MAC_TABLE_FID] = GENMASK(19, 16),
415415
[DYNAMIC_MAC_TABLE_SRC_PORT] = GENMASK(21, 20),
416416
[DYNAMIC_MAC_TABLE_TIMESTAMP] = GENMASK(23, 22),
@@ -420,7 +420,7 @@ static u8 ksz8863_shifts[] = {
420420
[VLAN_TABLE_MEMBERSHIP_S] = 16,
421421
[STATIC_MAC_FWD_PORTS] = 16,
422422
[STATIC_MAC_FID] = 22,
423-
[DYNAMIC_MAC_ENTRIES_H] = 3,
423+
[DYNAMIC_MAC_ENTRIES_H] = 8,
424424
[DYNAMIC_MAC_ENTRIES] = 24,
425425
[DYNAMIC_MAC_FID] = 16,
426426
[DYNAMIC_MAC_TIMESTAMP] = 24,

0 commit comments

Comments
 (0)