Skip to content

Commit 5daba91

Browse files
Shang XiaoJingvinodkoul
authored andcommitted
phy: rockchip-inno-usb2: Fix missing clk_disable_unprepare() in rockchip_usb2phy_power_on()
The clk_disable_unprepare() should be called in the error handling of rockchip_usb2phy_power_on(). Fixes: 0e08d2a ("phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy") Signed-off-by: Shang XiaoJing <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent ec4a1d9 commit 5daba91

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/phy/rockchip/phy-rockchip-inno-usb2.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -485,8 +485,10 @@ static int rockchip_usb2phy_power_on(struct phy *phy)
485485
return ret;
486486

487487
ret = property_enable(base, &rport->port_cfg->phy_sus, false);
488-
if (ret)
488+
if (ret) {
489+
clk_disable_unprepare(rphy->clk480m);
489490
return ret;
491+
}
490492

491493
/* waiting for the utmi_clk to become stable */
492494
usleep_range(1500, 2000);

0 commit comments

Comments
 (0)