Skip to content

Commit 5e25a8c

Browse files
Roderick ColenbranderJiri Kosina
authored andcommitted
HID: playstation: fix DualShock4 unreachable calibration code.
Reported-by: Abaci Robot <[email protected]> Reported-by: Jiapeng Chong <[email protected]> Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Roderick Colenbrander <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent 4f1f391 commit 5e25a8c

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/hid/hid-playstation.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1759,11 +1759,10 @@ static int dualshock4_get_calibration_data(struct dualshock4 *ds4)
17591759
if (retries < 2) {
17601760
hid_warn(hdev, "Retrying DualShock 4 get calibration report (0x02) request\n");
17611761
continue;
1762-
} else {
1763-
ret = -EILSEQ;
1764-
goto err_free;
17651762
}
1763+
17661764
hid_err(hdev, "Failed to retrieve DualShock4 calibration info: %d\n", ret);
1765+
ret = -EILSEQ;
17671766
goto err_free;
17681767
} else {
17691768
break;

0 commit comments

Comments
 (0)