Skip to content

Commit 5e799a7

Browse files
tititiou36joergroedel
authored andcommitted
iommu/exynos: Use the devm_clk_get_optional() helper
Use devm_clk_get_optional() instead of hand writing it. This saves some loC and improves the semantic. Signed-off-by: Christophe JAILLET <[email protected]> Acked-by: Marek Szyprowski <[email protected]> Link: https://lore.kernel.org/r/99c0d5ce643737ee0952df41fd60433a0bbeb447.1679834256.git.christophe.jaillet@wanadoo.fr Signed-off-by: Joerg Roedel <[email protected]>
1 parent e8d018d commit 5e799a7

File tree

1 file changed

+8
-16
lines changed

1 file changed

+8
-16
lines changed

drivers/iommu/exynos-iommu.c

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -747,33 +747,25 @@ static int exynos_sysmmu_probe(struct platform_device *pdev)
747747
return ret;
748748
}
749749

750-
data->clk = devm_clk_get(dev, "sysmmu");
751-
if (PTR_ERR(data->clk) == -ENOENT)
752-
data->clk = NULL;
753-
else if (IS_ERR(data->clk))
750+
data->clk = devm_clk_get_optional(dev, "sysmmu");
751+
if (IS_ERR(data->clk))
754752
return PTR_ERR(data->clk);
755753

756-
data->aclk = devm_clk_get(dev, "aclk");
757-
if (PTR_ERR(data->aclk) == -ENOENT)
758-
data->aclk = NULL;
759-
else if (IS_ERR(data->aclk))
754+
data->aclk = devm_clk_get_optional(dev, "aclk");
755+
if (IS_ERR(data->aclk))
760756
return PTR_ERR(data->aclk);
761757

762-
data->pclk = devm_clk_get(dev, "pclk");
763-
if (PTR_ERR(data->pclk) == -ENOENT)
764-
data->pclk = NULL;
765-
else if (IS_ERR(data->pclk))
758+
data->pclk = devm_clk_get_optional(dev, "pclk");
759+
if (IS_ERR(data->pclk))
766760
return PTR_ERR(data->pclk);
767761

768762
if (!data->clk && (!data->aclk || !data->pclk)) {
769763
dev_err(dev, "Failed to get device clock(s)!\n");
770764
return -ENOSYS;
771765
}
772766

773-
data->clk_master = devm_clk_get(dev, "master");
774-
if (PTR_ERR(data->clk_master) == -ENOENT)
775-
data->clk_master = NULL;
776-
else if (IS_ERR(data->clk_master))
767+
data->clk_master = devm_clk_get_optional(dev, "master");
768+
if (IS_ERR(data->clk_master))
777769
return PTR_ERR(data->clk_master);
778770

779771
data->sysmmu = dev;

0 commit comments

Comments
 (0)