Skip to content

Commit 5ee70be

Browse files
ying zuxinhdeller
authored andcommitted
fbdev: mmp: Use devm_clk_get_enabled() helpers
The devm_clk_get_enabled() helpers: - call devm_clk_get() - call clk_prepare_enable() and register what is needed in order to call clk_disable_unprepare() when needed, as a managed resource. This simplifies the code and avoids the calls to clk_disable_unprepare(). Signed-off-by: ying zuxin <[email protected]> Signed-off-by: Helge Deller <[email protected]>
1 parent aa578e8 commit 5ee70be

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

drivers/video/fbdev/mmp/hw/mmp_ctrl.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -512,16 +512,13 @@ static int mmphw_probe(struct platform_device *pdev)
512512
}
513513

514514
/* get clock */
515-
ctrl->clk = devm_clk_get(ctrl->dev, mi->clk_name);
515+
ctrl->clk = devm_clk_get_enabled(ctrl->dev, mi->clk_name);
516516
if (IS_ERR(ctrl->clk)) {
517517
ret = PTR_ERR(ctrl->clk);
518518
dev_err_probe(ctrl->dev, ret,
519519
"unable to get clk %s\n", mi->clk_name);
520520
goto failed;
521521
}
522-
ret = clk_prepare_enable(ctrl->clk);
523-
if (ret)
524-
goto failed;
525522

526523
/* init global regs */
527524
ctrl_set_default(ctrl);
@@ -556,7 +553,6 @@ static int mmphw_probe(struct platform_device *pdev)
556553
path_deinit(path_plat);
557554
}
558555

559-
clk_disable_unprepare(ctrl->clk);
560556
failed:
561557
dev_err(&pdev->dev, "device init failed\n");
562558

0 commit comments

Comments
 (0)