Skip to content

Commit 5f262f6

Browse files
floatiouskwilczynski
authored andcommitted
dt-bindings: PCI: rockchip-dw-pcie: Fix description of legacy IRQ
The descriptions of the combined interrupt signals (level1) mention all the lower interrupt signals (level2) for each combined interrupt, regardless if the lower (level2) signal is RC or EP specific. E.g. the description of "Combined system interrupt" includes rbar_update, which is EP specific, and the description of "Combined message interrupt" includes obff_idle, obff_obff, obff_cpu_active, which are all EP specific. The only exception is the "Combined legacy interrupt", which for some reason does not provide an exhaustive list of the lower (level2) signals. Add the missing lower interrupt signals: tx_inta, tx_intb, tx_intc, and tx_intd for the "Combined legacy interrupt", as per the rk3568 and rk3588 Technical Reference Manuals, such that the descriptions of the combined interrupt signals are consistent. Link: https://lore.kernel.org/linux-pci/[email protected] Signed-off-by: Niklas Cassel <[email protected]> Signed-off-by: Krzysztof Wilczyński <[email protected]> Reviewed-by: Manivannan Sadhasivam <[email protected]> Reviewed-by: Rob Herring (Arm) <[email protected]>
1 parent 9b0b9b5 commit 5f262f6

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,8 @@ properties:
5656
pm_pme, pm_to_ack, pm_turnoff, obff_idle, obff_obff, obff_cpu_active
5757
- description:
5858
Combined legacy interrupt, which is used to signal the following
59-
interrupts - inta, intb, intc, intd
59+
interrupts - inta, intb, intc, intd, tx_inta, tx_intb, tx_intc,
60+
tx_intd
6061
- description:
6162
Combined error interrupt, which is used to signal the following
6263
interrupts - aer_rc_err, aer_rc_err_msi, rx_cpl_timeout,

0 commit comments

Comments
 (0)